From: Boris Brezillon <boris.brezillon@collabora.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Michal Simek <monstr@monstr.eu>,
Vignesh Raghavendra <vigneshr@ti.com>,
Tudor Ambarus <Tudor.Ambarus@microchip.com>,
Richard Weinberger <richard@nod.at>,
linux-mtd@lists.infradead.org,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Naga Sureshkumar Relli <nagasure@xilinx.com>
Subject: Re: [PATCH v5 3/8] mtd: rawnand: Ensure the number of bitflips is consistent
Date: Tue, 19 May 2020 10:42:05 +0200 [thread overview]
Message-ID: <20200519104205.7c130931@collabora.com> (raw)
In-Reply-To: <20200519074549.23673-4-miquel.raynal@bootlin.com>
On Tue, 19 May 2020 09:45:44 +0200
Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> The main NAND read page function can loop over "page reads" many times
> in if the reading reports uncorrectable error(s) and if the chip
> supports the read_retry feature.
>
> In this case, the number of bitflips is summarized between
> attempts. Fix this by re-initializing the entire mtd_ecc_stats object
> each time we retry.
>
> Suggested-by: Boris Brezillon <boris.brezillon@collabora.com>
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
> ---
> drivers/mtd/nand/raw/nand_base.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/mtd/nand/raw/nand_base.c b/drivers/mtd/nand/raw/nand_base.c
> index 2bef01e21533..65e9b2fa2fc5 100644
> --- a/drivers/mtd/nand/raw/nand_base.c
> +++ b/drivers/mtd/nand/raw/nand_base.c
> @@ -3288,7 +3288,7 @@ static int nand_do_read_ops(struct nand_chip *chip, loff_t from,
> oob_required = oob ? 1 : 0;
>
> while (1) {
> - unsigned int ecc_failures = mtd->ecc_stats.failed;
> + struct mtd_ecc_stats ecc_stats = mtd->ecc_stats;
>
> bytes = min(mtd->writesize - col, readlen);
> aligned = (bytes == mtd->writesize);
> @@ -3339,7 +3339,7 @@ static int nand_do_read_ops(struct nand_chip *chip, loff_t from,
> */
> if (use_bounce_buf) {
> if (!NAND_HAS_SUBPAGE_READ(chip) && !oob &&
> - !(mtd->ecc_stats.failed - ecc_failures) &&
> + !(mtd->ecc_stats.failed - ecc_stats.failed) &&
> (ops->mode != MTD_OPS_RAW)) {
> chip->pagecache.page = realpage;
> chip->pagecache.bitflips = ret;
> @@ -3362,7 +3362,7 @@ static int nand_do_read_ops(struct nand_chip *chip, loff_t from,
>
> nand_wait_readrdy(chip);
>
> - if (mtd->ecc_stats.failed - ecc_failures) {
> + if (mtd->ecc_stats.failed - ecc_stats.failed) {
> if (retry_mode + 1 < chip->read_retries) {
> retry_mode++;
> ret = nand_setup_read_retry(chip,
> @@ -3370,8 +3370,8 @@ static int nand_do_read_ops(struct nand_chip *chip, loff_t from,
> if (ret < 0)
> break;
>
> - /* Reset failures; retry */
> - mtd->ecc_stats.failed = ecc_failures;
> + /* Reset ecc_stats; retry */
> + mtd->ecc_stats = ecc_stats;
> goto read_retry;
> } else {
> /* No more retry modes; real failure */
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2020-05-19 8:42 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 7:45 [PATCH v5 0/8] New Arasan NAND controller driver Miquel Raynal
2020-05-19 7:45 ` [PATCH v5 1/8] lib/bch: Rework a little bit the exported function names Miquel Raynal
2020-05-24 19:10 ` Miquel Raynal
2020-05-19 7:45 ` [PATCH v5 2/8] lib/bch: Allow easy bit swapping Miquel Raynal
2020-05-19 8:41 ` Boris Brezillon
2020-05-24 19:09 ` Miquel Raynal
2020-05-19 7:45 ` [PATCH v5 3/8] mtd: rawnand: Ensure the number of bitflips is consistent Miquel Raynal
2020-05-19 8:42 ` Boris Brezillon [this message]
2020-05-24 19:09 ` Miquel Raynal
2020-05-19 7:45 ` [PATCH v5 4/8] mtd: rawnand: Add nand_extract_bits() Miquel Raynal
2020-05-19 8:48 ` Boris Brezillon
2020-05-19 12:15 ` Miquel Raynal
2020-05-24 19:09 ` Miquel Raynal
2020-05-19 7:45 ` [PATCH v5 5/8] MAINTAINERS: Add Arasan NAND controller and bindings Miquel Raynal
2020-05-24 19:09 ` Miquel Raynal
2020-05-19 7:45 ` [PATCH v5 6/8] dt-bindings: mtd: Document ARASAN NAND bindings Miquel Raynal
2020-05-24 19:09 ` Miquel Raynal
2020-05-19 7:45 ` [PATCH v5 7/8] mtd: rawnand: arasan: Add new Arasan NAND controller Miquel Raynal
2020-05-19 8:50 ` Boris Brezillon
2020-05-24 19:09 ` Miquel Raynal
2020-05-19 7:45 ` [PATCH v5 8/8] mtd: rawnand: arasan: Support the hardware BCH ECC engine Miquel Raynal
2020-05-19 8:51 ` Boris Brezillon
2020-05-24 19:09 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200519104205.7c130931@collabora.com \
--to=boris.brezillon@collabora.com \
--cc=Tudor.Ambarus@microchip.com \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=monstr@monstr.eu \
--cc=nagasure@xilinx.com \
--cc=richard@nod.at \
--cc=thomas.petazzoni@bootlin.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).