From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E4C3C433DF for ; Mon, 25 May 2020 18:34:01 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5201C20671 for ; Mon, 25 May 2020 18:34:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="MgUfZIGP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5201C20671 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=v9WdAzwI/ubsILjPBLXlDV65KS2hGGypRPFk9YOT670=; b=MgUfZIGPq3PnMH 1FVbmJ7RVDBapgAnTSGn1zRHE4AEMLXMP9MaMdASomMUHkqWaAfrkeOdE2iWqOoW5lLQ0upmc00/Z /w80XqA9f+VnMeINgujRncI320tSVx6NMYWFjXtJTrKVoiYWZhA1opPDcOQopIG97DBSE5NoHHA84 PPc+Aqk++WUj0hxttOS/fpUcSadspeuy7XFhKtgW+2p4egfG9JvigZBdVE7Nm50s+v4tU9FKseO9e nMRDUuWODDc2r8ZzVzqNMYsJls48FclZu9HUxbsYXktf4DaLrdSEHWShY1aLEyiF/JSwdNTyOwOTF cUfOzEYv98PodSdz4XcA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jdHvC-0001jn-8i; Mon, 25 May 2020 18:33:58 +0000 Received: from bhuna.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e3e3]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jdHvA-0001jG-0a for linux-mtd@lists.infradead.org; Mon, 25 May 2020 18:33:57 +0000 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 2B9F92A1899; Mon, 25 May 2020 19:33:51 +0100 (BST) Date: Mon, 25 May 2020 20:33:48 +0200 From: Boris Brezillon To: Miquel Raynal Subject: Re: [PATCH v4 01/19] mtd: rawnand: Use unsigned types for nand_chip unsigned values Message-ID: <20200525203348.7c41a7eb@collabora.com> In-Reply-To: <20200525174239.11349-2-miquel.raynal@bootlin.com> References: <20200525174239.11349-1-miquel.raynal@bootlin.com> <20200525174239.11349-2-miquel.raynal@bootlin.com> Organization: Collabora X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200525_113356_184000_17A556AD X-CRM114-Status: GOOD ( 14.25 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rickard Andersson , Richard Weinberger , linux-mtd@lists.infradead.org, Vignesh Raghavendra , Tudor Ambarus Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Mon, 25 May 2020 19:42:21 +0200 Miquel Raynal wrote: > page_shift, phys_erase_shift, bbt_erase_shift, chip_shift, pagemask, > subpagesize and badblockbits are all positive values, so declare > them as unsigned. > > Signed-off-by: Miquel Raynal Reviewed-by: Boris Brezillon though patching code to get rid of those fields (in favor of nanddev_xxx() calls) would be much more valuable IMHO. > --- > include/linux/mtd/rawnand.h | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/include/linux/mtd/rawnand.h b/include/linux/mtd/rawnand.h > index 2804c13e5662..8a1e0192f78e 100644 > --- a/include/linux/mtd/rawnand.h > +++ b/include/linux/mtd/rawnand.h > @@ -1110,11 +1110,11 @@ struct nand_chip { > unsigned int options; > unsigned int bbt_options; > > - int page_shift; > - int phys_erase_shift; > - int bbt_erase_shift; > - int chip_shift; > - int pagemask; > + unsigned int page_shift; > + unsigned int phys_erase_shift; > + unsigned int bbt_erase_shift; > + unsigned int chip_shift; > + unsigned int pagemask; > u8 *data_buf; > > struct { > @@ -1122,10 +1122,10 @@ struct nand_chip { > int page; > } pagecache; > > - int subpagesize; > + unsigned int subpagesize; > int onfi_timing_mode_default; > unsigned int badblockpos; > - int badblockbits; > + unsigned int badblockbits; > > struct nand_id id; > struct nand_parameters parameters; ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/