From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E61CC433E0 for ; Mon, 25 May 2020 19:10:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 43E9020671 for ; Mon, 25 May 2020 19:10:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="fR2HW/nM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 43E9020671 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hk72w4GDoFaJEwSc2M6vVP4cFitI8Y++aE8EUvAP3/U=; b=fR2HW/nM7f9R8z 0C2IIHMwPSPvAGspttdAtA4XtyZp8fEbk5PdbAv+lS+LEfZeLHrlMrP7N9iwXioWNpwuYGXKvr4x/ 6Dywj4nmgH6qC7bbh2WaG/5/LyvNIttezRAzItCaHyGYdVVLmd7azb7v2BNk5ppG5co+lK/7FeoeB 6JvufZgCBrD7A9rxGOGw+HD89ZbLHFk/fs3hwz4NtvvJhvwIHNf8lyRQwmE52auDUIrkEUpZ6mrS0 lTBjzvK3GMPqHbRQOwHPVbv6uExNtaz7ZAdlUkd1abNRcagZ9i+gfH7tbd147gPRcE6DFfpEfimfe EDH8AJejt0XR1SjrQ9oQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jdIUN-0001CR-TI; Mon, 25 May 2020 19:10:19 +0000 Received: from bhuna.collabora.co.uk ([46.235.227.227]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jdIUL-0001Bx-Rp for linux-mtd@lists.infradead.org; Mon, 25 May 2020 19:10:19 +0000 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 92DE72A0E00; Mon, 25 May 2020 20:10:16 +0100 (BST) Date: Mon, 25 May 2020 21:10:13 +0200 From: Boris Brezillon To: Miquel Raynal Subject: Re: [PATCH v4 10/19] mtd: rawnand: Rename nand_has_setup_data_interface() Message-ID: <20200525211013.641cf36f@collabora.com> In-Reply-To: <20200525174239.11349-11-miquel.raynal@bootlin.com> References: <20200525174239.11349-1-miquel.raynal@bootlin.com> <20200525174239.11349-11-miquel.raynal@bootlin.com> Organization: Collabora X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200525_121018_034572_6614527E X-CRM114-Status: GOOD ( 19.87 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rickard Andersson , Richard Weinberger , linux-mtd@lists.infradead.org, Vignesh Raghavendra , Tudor Ambarus Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Mon, 25 May 2020 19:42:30 +0200 Miquel Raynal wrote: > This is really a NAND controller hook so call it > nand_controller_has_setup_data_interface(), which makes much more > sense. > > Signed-off-by: Miquel Raynal Reviewed-by: Boris Brezillon > --- > drivers/mtd/nand/raw/internals.h | 2 +- > drivers/mtd/nand/raw/nand_base.c | 6 +++--- > drivers/mtd/nand/raw/nand_legacy.c | 2 +- > 3 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/mtd/nand/raw/internals.h b/drivers/mtd/nand/raw/internals.h > index a518acfd9b3f..347d42c55353 100644 > --- a/drivers/mtd/nand/raw/internals.h > +++ b/drivers/mtd/nand/raw/internals.h > @@ -130,7 +130,7 @@ static inline int nand_exec_op(struct nand_chip *chip, > return chip->controller->ops->exec_op(chip, op, false); > } > > -static inline bool nand_has_setup_data_iface(struct nand_chip *chip) > +static inline bool nand_controller_has_setup_data_iface(struct nand_chip *chip) > { > if (!chip->controller || !chip->controller->ops || > !chip->controller->ops->setup_data_interface) > diff --git a/drivers/mtd/nand/raw/nand_base.c b/drivers/mtd/nand/raw/nand_base.c > index 514ac78899ec..d446394a2ea0 100644 > --- a/drivers/mtd/nand/raw/nand_base.c > +++ b/drivers/mtd/nand/raw/nand_base.c > @@ -910,7 +910,7 @@ static int nand_reset_data_interface(struct nand_chip *chip, int chipnr) > { > int ret; > > - if (!nand_has_setup_data_iface(chip)) > + if (!nand_controller_has_setup_data_iface(chip)) > return 0; > > /* > @@ -955,7 +955,7 @@ static int nand_setup_data_interface(struct nand_chip *chip, int chipnr) > u8 tmode_param[ONFI_SUBFEATURE_PARAM_LEN] = { mode, }; > int ret; > > - if (!nand_has_setup_data_iface(chip)) > + if (!nand_controller_has_setup_data_iface(chip)) > return 0; > > /* Change the mode on the chip side (if supported by the NAND chip) */ > @@ -1024,7 +1024,7 @@ static int nand_init_data_interface(struct nand_chip *chip) > { > int modes, mode, ret; > > - if (!nand_has_setup_data_iface(chip)) > + if (!nand_controller_has_setup_data_iface(chip)) > return 0; > > /* > diff --git a/drivers/mtd/nand/raw/nand_legacy.c b/drivers/mtd/nand/raw/nand_legacy.c > index d64791c06a97..8b91aa7773d8 100644 > --- a/drivers/mtd/nand/raw/nand_legacy.c > +++ b/drivers/mtd/nand/raw/nand_legacy.c > @@ -365,7 +365,7 @@ static void nand_ccs_delay(struct nand_chip *chip) > * Wait tCCS_min if it is correctly defined, otherwise wait 500ns > * (which should be safe for all NANDs). > */ > - if (nand_has_setup_data_iface(chip)) > + if (nand_controller_has_setup_data_iface(chip)) > ndelay(chip->data_interface.timings.sdr.tCCS_min / 1000); > else > ndelay(500); ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/