From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5819C433E0 for ; Tue, 26 May 2020 20:33:39 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A4CE32065F for ; Tue, 26 May 2020 20:33:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rntJZRCU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A4CE32065F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CVk7AQOc7kkRKTpOZw18r6+DGAho6jIoSJDETCoyttw=; b=rntJZRCUV7sbPE sL3A2DdaLCRkfM8fvujZxUz70DSl3/noIjKzyfG4GKQHJkifQKw66uXZpzBD0mGeuuhFVizJ6GDty NmhEV2xDknEVxfk0sgQUoZvrlMmB49t8nTyr8oQbb34sl/s49ZKDPsZjV0rvLEXOBh4legfoJmbvU 1qDm6+eVuu1nI0E8wl/Ou60dLaEQOHv2DO7qcQ8elfpHcZS0ICWiSrkSc07K8zwE619Gg+unQIzxr 9kslYJ2Ksh2p2945whp15/tIMvkMOA1GNMj9tmmH2lIiVzNf9D3/F4cEWHVSHqvCRcih/Ttx+EaN0 yBd+BgsBNaJavw2jLXEQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jdgGO-0000YZ-Ou; Tue, 26 May 2020 20:33:28 +0000 Received: from bhuna.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e3e3]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jdgGL-0000YF-JQ for linux-mtd@lists.infradead.org; Tue, 26 May 2020 20:33:26 +0000 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 4E7FF2A2AB8; Tue, 26 May 2020 21:33:24 +0100 (BST) Date: Tue, 26 May 2020 22:33:21 +0200 From: Boris Brezillon To: Miquel Raynal Subject: Re: [PATCH v5 15/28] mtd: rawnand: timings: Avoid redefining tR_max and tCCS_min Message-ID: <20200526223321.63903e51@collabora.com> In-Reply-To: <20200526191725.7591-16-miquel.raynal@bootlin.com> References: <20200526191725.7591-1-miquel.raynal@bootlin.com> <20200526191725.7591-16-miquel.raynal@bootlin.com> Organization: Collabora X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200526_133325_762761_FA6A27E0 X-CRM114-Status: GOOD ( 13.96 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rickard Andersson , Richard Weinberger , linux-mtd@lists.infradead.org, Vignesh Raghavendra , Tudor Ambarus Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Tue, 26 May 2020 21:17:12 +0200 Miquel Raynal wrote: > These two values are already hardcoded in the default ONFI timing > structure, no need to redefine them here. > > Signed-off-by: Miquel Raynal > --- > drivers/mtd/nand/raw/nand_timings.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/mtd/nand/raw/nand_timings.c b/drivers/mtd/nand/raw/nand_timings.c > index 3c44c4b90536..c2286a75d134 100644 > --- a/drivers/mtd/nand/raw/nand_timings.c > +++ b/drivers/mtd/nand/raw/nand_timings.c > @@ -371,9 +371,6 @@ int onfi_fill_data_interface(struct nand_chip *chip, > /* microseconds -> picoseconds */ > timings->tPROG_max = 1000000ULL * ONFI_DYN_TIMING_MAX; > timings->tBERS_max = 1000000ULL * ONFI_DYN_TIMING_MAX; > - > - timings->tR_max = 200000000; > - timings->tCCS_min = 500000; I'd rather drop the definitions in the ONFI timings and keep that one. > } > > return 0; ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/