From: Boris Brezillon <boris.brezillon@collabora.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Rickard Andersson <rickaran@axis.com>,
Richard Weinberger <richard@nod.at>,
linux-mtd@lists.infradead.org,
Vignesh Raghavendra <vigneshr@ti.com>,
Tudor Ambarus <Tudor.Ambarus@microchip.com>
Subject: Re: [PATCH v5 16/28] mtd: rawnand: timings: Use default values for tPROG_max and tBERS_max
Date: Tue, 26 May 2020 23:25:30 +0200 [thread overview]
Message-ID: <20200526232530.5c9008f1@collabora.com> (raw)
In-Reply-To: <20200526191725.7591-17-miquel.raynal@bootlin.com>
On Tue, 26 May 2020 21:17:13 +0200
Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> The ONFI parameter page of a chip might define more fine grained
> tPROG_max and tBERS_max. When we do not have this information, we
> default to the highest possible values (they are maxima anyway).
>
> There is no point setting these fields at runtime, so explicitly move
> these defaults to the main ONFI SDR timings structure.
Okay, now I see why you're doing that: you want to return the mode 0
entry directly, and it makes sense, but it should be explained in the
commit message.
>
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> ---
> drivers/mtd/nand/raw/nand_timings.c | 24 ++++++++++++------------
> 1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/mtd/nand/raw/nand_timings.c b/drivers/mtd/nand/raw/nand_timings.c
> index c2286a75d134..52ee83e75646 100644
> --- a/drivers/mtd/nand/raw/nand_timings.c
> +++ b/drivers/mtd/nand/raw/nand_timings.c
> @@ -20,6 +20,8 @@ static const struct nand_data_interface onfi_sdr_timings[] = {
> .timings.sdr = {
> .tCCS_min = 500000,
> .tR_max = 200000000,
> + .tPROG_max = 1000000ULL * ONFI_DYN_TIMING_MAX,
> + .tBERS_max = 1000000ULL * ONFI_DYN_TIMING_MAX,
> .tADL_min = 400000,
> .tALH_min = 20000,
> .tALS_min = 50000,
> @@ -63,6 +65,8 @@ static const struct nand_data_interface onfi_sdr_timings[] = {
> .timings.sdr = {
> .tCCS_min = 500000,
> .tR_max = 200000000,
> + .tPROG_max = 1000000ULL * ONFI_DYN_TIMING_MAX,
> + .tBERS_max = 1000000ULL * ONFI_DYN_TIMING_MAX,
> .tADL_min = 400000,
> .tALH_min = 10000,
> .tALS_min = 25000,
> @@ -106,6 +110,8 @@ static const struct nand_data_interface onfi_sdr_timings[] = {
> .timings.sdr = {
> .tCCS_min = 500000,
> .tR_max = 200000000,
> + .tPROG_max = 1000000ULL * ONFI_DYN_TIMING_MAX,
> + .tBERS_max = 1000000ULL * ONFI_DYN_TIMING_MAX,
> .tADL_min = 400000,
> .tALH_min = 10000,
> .tALS_min = 15000,
> @@ -149,6 +155,8 @@ static const struct nand_data_interface onfi_sdr_timings[] = {
> .timings.sdr = {
> .tCCS_min = 500000,
> .tR_max = 200000000,
> + .tPROG_max = 1000000ULL * ONFI_DYN_TIMING_MAX,
> + .tBERS_max = 1000000ULL * ONFI_DYN_TIMING_MAX,
> .tADL_min = 400000,
> .tALH_min = 5000,
> .tALS_min = 10000,
> @@ -192,6 +200,8 @@ static const struct nand_data_interface onfi_sdr_timings[] = {
> .timings.sdr = {
> .tCCS_min = 500000,
> .tR_max = 200000000,
> + .tPROG_max = 1000000ULL * ONFI_DYN_TIMING_MAX,
> + .tBERS_max = 1000000ULL * ONFI_DYN_TIMING_MAX,
> .tADL_min = 400000,
> .tALH_min = 5000,
> .tALS_min = 10000,
> @@ -235,6 +245,8 @@ static const struct nand_data_interface onfi_sdr_timings[] = {
> .timings.sdr = {
> .tCCS_min = 500000,
> .tR_max = 200000000,
> + .tPROG_max = 1000000ULL * ONFI_DYN_TIMING_MAX,
> + .tBERS_max = 1000000ULL * ONFI_DYN_TIMING_MAX,
> .tADL_min = 400000,
> .tALH_min = 5000,
> .tALS_min = 10000,
> @@ -359,18 +371,6 @@ int onfi_fill_data_interface(struct nand_chip *chip,
>
> /* nanoseconds -> picoseconds */
> timings->tCCS_min = 1000UL * onfi->tCCS;
> - } else {
> - struct nand_sdr_timings *timings = &iface->timings.sdr;
> - /*
> - * For non-ONFI chips we use the highest possible value for
> - * tPROG and tBERS. tR and tCCS will take the default values
> - * precised in the ONFI specification for timing mode 0,
> - * respectively 200us and 500ns.
> - */
> -
> - /* microseconds -> picoseconds */
> - timings->tPROG_max = 1000000ULL * ONFI_DYN_TIMING_MAX;
> - timings->tBERS_max = 1000000ULL * ONFI_DYN_TIMING_MAX;
> }
>
> return 0;
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2020-05-26 21:25 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-26 19:16 [PATCH v5 00/28] Allow vendor drivers to propose their own timings Miquel Raynal
2020-05-26 19:16 ` [PATCH v5 01/28] mtd: rawnand: Use unsigned types for nand_chip unsigned values Miquel Raynal
2020-05-26 19:16 ` [PATCH v5 02/28] mtd: rawnand: Only use u8 instead of uint8_t in nand_chip structure Miquel Raynal
2020-05-26 19:17 ` [PATCH v5 03/28] mtd: rawnand: Create a nand_chip operations structure Miquel Raynal
2020-05-26 19:17 ` [PATCH v5 04/28] mtd: rawnand: Rename the manufacturer structure Miquel Raynal
2020-05-26 19:17 ` [PATCH v5 05/28] mtd: rawnand: Declare the nand_manufacturer structure out of nand_chip Miquel Raynal
2020-05-26 19:17 ` [PATCH v5 06/28] mtd: rawnand: Reorganize the nand_chip structure Miquel Raynal
2020-05-26 19:17 ` [PATCH v5 07/28] mtd: rawnand: Compare the actual timing values Miquel Raynal
2020-05-26 19:17 ` [PATCH v5 08/28] mtd: rawnand: Use the data interface mode entry when relevant Miquel Raynal
2020-05-26 19:17 ` [PATCH v5 09/28] mtd: rawnand: Rename nand_has_setup_data_interface() Miquel Raynal
2020-05-26 19:17 ` [PATCH v5 10/28] mtd: rawnand: Fix nand_setup_data_interface() description Miquel Raynal
2020-05-26 19:17 ` [PATCH v5 11/28] mtd: rawnand: Rename nand_init_data_interface() Miquel Raynal
2020-05-26 19:17 ` [PATCH v5 12/28] mtd: rawnand: timings: Update onfi_fill_data_interface() kernel doc Miquel Raynal
2020-05-26 19:17 ` [PATCH v5 13/28] mtd: rawnand: timings: Provide onfi_fill_data_interface() with a data interface Miquel Raynal
2020-05-26 19:17 ` [PATCH v5 14/28] mtd: rawnand: timings: Add a helper to find the closest ONFI mode Miquel Raynal
2020-05-26 21:42 ` Boris Brezillon
2020-05-27 7:42 ` Miquel Raynal
2020-05-26 19:17 ` [PATCH v5 15/28] mtd: rawnand: timings: Avoid redefining tR_max and tCCS_min Miquel Raynal
2020-05-26 20:33 ` Boris Brezillon
2020-05-26 19:17 ` [PATCH v5 16/28] mtd: rawnand: timings: Use default values for tPROG_max and tBERS_max Miquel Raynal
2020-05-26 20:32 ` Boris Brezillon
2020-05-26 21:25 ` Boris Brezillon [this message]
2020-05-27 7:17 ` Miquel Raynal
2020-05-27 7:22 ` Miquel Raynal
2020-05-27 7:28 ` Boris Brezillon
2020-05-26 19:17 ` [PATCH v5 17/28] mtd: rawnand: Define a unique reset data interface Miquel Raynal
2020-05-26 21:23 ` Boris Brezillon
2020-05-27 7:20 ` Miquel Raynal
2020-05-27 8:10 ` Boris Brezillon
2020-05-26 19:17 ` [PATCH v5 18/28] mtd: rawnand: marvell: Use a helper to access the timings Miquel Raynal
2020-05-26 21:26 ` Boris Brezillon
2020-05-26 19:17 ` [PATCH v5 19/28] mtd: rawnand: legacy: " Miquel Raynal
2020-05-26 21:28 ` Boris Brezillon
2020-05-26 19:17 ` [PATCH v5 20/28] mtd: rawnand: Hide the chip->data_interface indirection Miquel Raynal
2020-05-26 21:36 ` Boris Brezillon
2020-05-27 7:36 ` Miquel Raynal
2020-05-27 8:14 ` Boris Brezillon
2020-05-26 19:17 ` [PATCH v5 21/28] mtd: rawnand: Introduce nand_choose_best_sdr_timings() Miquel Raynal
2020-05-26 21:50 ` Boris Brezillon
2020-05-27 7:45 ` Miquel Raynal
2020-05-26 19:17 ` [PATCH v5 22/28] mtd: rawnand: Add the ->choose_data_interface() hook Miquel Raynal
2020-05-26 21:52 ` Boris Brezillon
2020-05-27 7:46 ` Miquel Raynal
2020-05-26 19:17 ` [PATCH v5 23/28] mtd: rawnand: toshiba: Implement ->choose_data_interface() for TC58TEG5DCLTA00 Miquel Raynal
2020-05-26 21:54 ` Boris Brezillon
2020-05-26 19:17 ` [PATCH v5 24/28] mtd: rawnand: toshiba: Implement ->choose_data_interface() for TC58NVG0S3E Miquel Raynal
2020-05-26 22:02 ` Boris Brezillon
2020-05-27 7:47 ` Miquel Raynal
2020-05-26 19:17 ` [PATCH v5 25/28] mtd: rawnand: hynix: Implement ->choose_data_interface() for H27UCG8T2ATR-BC Miquel Raynal
2020-05-26 22:06 ` Boris Brezillon
2020-05-27 7:50 ` Miquel Raynal
2020-05-26 19:17 ` [PATCH v5 26/28] mtd: rawnand: toshiba: Choose the data interface for TH58NVG2S3HBAI4 Miquel Raynal
2020-05-26 22:10 ` Boris Brezillon
2020-05-26 19:17 ` [PATCH v5 27/28] mtd: rawnand: Get rid of the default ONFI timing mode Miquel Raynal
2020-05-26 22:13 ` Boris Brezillon
2020-05-26 19:17 ` [PATCH v5 28/28] mtd: rawnand: Allocate the best data interface structure dynamically Miquel Raynal
2020-05-26 22:28 ` Boris Brezillon
2020-05-27 7:57 ` Miquel Raynal
2020-05-27 8:35 ` Boris Brezillon
2020-05-27 8:49 ` Miquel Raynal
2020-05-27 8:57 ` Boris Brezillon
2020-05-27 9:34 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200526232530.5c9008f1@collabora.com \
--to=boris.brezillon@collabora.com \
--cc=Tudor.Ambarus@microchip.com \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=rickaran@axis.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).