From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B786AC433E0 for ; Tue, 26 May 2020 21:36:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 85384208B8 for ; Tue, 26 May 2020 21:36:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="MCIfm+xO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 85384208B8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5Nh+tnTwG/L4Kumoa6H0ay8UtF6g/0EEG1MXDsJcLjM=; b=MCIfm+xONsM+9i +HvsctSjQX3sZtnUQ0ygaNtKed/El2z+/B9nsTDh7AUxScn/+njtnc2j0axmmABk24nUKSkfeLAPo 3iB+AEe9gbL/WaFzjV1a/hc/xhX7/6Pnqq8fVY82RJPuCA7cgZtFLcri/ldVv5o5HFlPt+ERsY8wL Tm3gMEI8czn50QkwKcLDW0IgZBAzNHDI823vZqXIhR6xG9EI8IK0C9yqNUlMhp8CDIJdqn/FY8tnF il4gw/zMvKIBtey2qG1Od1zER0MNzILNEXQMU7vguNZqxRZD2P8FSpM122Zamr4kzmbSM0UfDRbUx 47w2HlwFsacmfNi6yGdg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jdhFL-0005Ue-Eg; Tue, 26 May 2020 21:36:27 +0000 Received: from bhuna.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e3e3]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jdhFI-0005UI-Uv for linux-mtd@lists.infradead.org; Tue, 26 May 2020 21:36:26 +0000 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:b93f:9fae:b276:a89a]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id A765D2A35E4; Tue, 26 May 2020 22:36:23 +0100 (BST) Date: Tue, 26 May 2020 23:36:20 +0200 From: Boris Brezillon To: Miquel Raynal Subject: Re: [PATCH v5 20/28] mtd: rawnand: Hide the chip->data_interface indirection Message-ID: <20200526233620.44914f1f@collabora.com> In-Reply-To: <20200526191725.7591-21-miquel.raynal@bootlin.com> References: <20200526191725.7591-1-miquel.raynal@bootlin.com> <20200526191725.7591-21-miquel.raynal@bootlin.com> Organization: Collabora X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200526_143625_124134_7E02E125 X-CRM114-Status: GOOD ( 12.56 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rickard Andersson , Richard Weinberger , linux-mtd@lists.infradead.org, Vignesh Raghavendra , Tudor Ambarus Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Tue, 26 May 2020 21:17:17 +0200 Miquel Raynal wrote: > As a preparation for allocating the data interface structure > dynamically (and rename it), let's avoid calling it directly. > > Instead, we operate a rename on an existing helper to reuse that name > for another helper: > * s/nand_get_sdr_timings/nand_extract_sdr_timings/ > -> this helper just extracts timings from a given data interface Hm, I'm not entirely happy with that name. In my mind extract means that you had to do some transformation to get the data, which is not the case here. How about nand_data_interface_get_sdr_timings()? > * nand_get_sdr_timings() > -> this helper retrieves the in use timings from a nand_chip structure Do we really need that one? Can we do that in 2 steps instead? conf = nand_get_data_interface_config(chip); sdr = nand_data_interface_get_sdr_timings(conf); > > Signed-off-by: Miquel Raynal ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/