From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92DB3C433DF for ; Tue, 26 May 2020 21:52:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5DFC420707 for ; Tue, 26 May 2020 21:52:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="V/8PrmmW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5DFC420707 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aGhy6kPw0lcaNIoLGDfZx0YmXozUGK2afKAMiaV7CzA=; b=V/8PrmmWliXFm1 jYA8wYrHo8EIjuPxylpN2ye+WleB5pIyVsX+MHipco2U2zcUPhifqyV4HKMx1R3GL4Xnm43QmQ+E5 zksaxCLvF9G6Owx4go2gquf2c8fkWU+jXnn9I39I8wUCwuX/9tk2Uu2OsZ8F+r4VhYxM/M3cON9u7 mJ5lB8Zt4boZmJyscDpEiRNtCoHe5jLq6buzAlTk6CCbCVzjnulwSs5Ai9giF4XzYatAWIPPtOEWV MRJx1CIBHGemjwEoJHoFYiOlFZIcTK5ZuYCbLFhyPPhhhV2jWxZ4vpIZdpjLPxHuudHZNuvqsrVzL 6Yytd3si2lzxuLGkAJlA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jdhUu-0007Cl-AB; Tue, 26 May 2020 21:52:32 +0000 Received: from bhuna.collabora.co.uk ([46.235.227.227]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jdhUr-0007By-C0 for linux-mtd@lists.infradead.org; Tue, 26 May 2020 21:52:30 +0000 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:b93f:9fae:b276:a89a]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 0D2CD2A22AA; Tue, 26 May 2020 22:52:28 +0100 (BST) Date: Tue, 26 May 2020 23:52:25 +0200 From: Boris Brezillon To: Miquel Raynal Subject: Re: [PATCH v5 22/28] mtd: rawnand: Add the ->choose_data_interface() hook Message-ID: <20200526235225.6e0f0ce2@collabora.com> In-Reply-To: <20200526191725.7591-23-miquel.raynal@bootlin.com> References: <20200526191725.7591-1-miquel.raynal@bootlin.com> <20200526191725.7591-23-miquel.raynal@bootlin.com> Organization: Collabora X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200526_145229_540208_C05763AB X-CRM114-Status: GOOD ( 19.84 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rickard Andersson , Richard Weinberger , linux-mtd@lists.infradead.org, Vignesh Raghavendra , Tudor Ambarus Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Tue, 26 May 2020 21:17:19 +0200 Miquel Raynal wrote: > This hook can be overloaded by NAND manufacturer drivers to propose > alternative timings when not following the main standards. In this > case, the manufacturer drivers is responsible for choosing the best > data interface and configuration that fits both the controller and ^ s/and// > chip capabilities. > > Signed-off-by: Miquel Raynal > --- > drivers/mtd/nand/raw/nand_base.c | 9 +++++++-- > include/linux/mtd/rawnand.h | 3 +++ > 2 files changed, 10 insertions(+), 2 deletions(-) > > diff --git a/drivers/mtd/nand/raw/nand_base.c b/drivers/mtd/nand/raw/nand_base.c > index b2e833a8ab9d..f14d297c50f4 100644 > --- a/drivers/mtd/nand/raw/nand_base.c > +++ b/drivers/mtd/nand/raw/nand_base.c > @@ -1046,7 +1046,6 @@ int nand_choose_best_sdr_timings(struct nand_chip *chip, > } > } > > - Should this line removal be part of another patch? > for (mode = best_mode; mode >= 0; mode--) { > ret = onfi_fill_data_interface(chip, iface, NAND_SDR_IFACE, > mode); > @@ -1068,7 +1067,9 @@ int nand_choose_best_sdr_timings(struct nand_chip *chip, > * @chip: The NAND chip > * > * Find the best data interface and NAND timings supported by the chip > - * and the driver. > + * and the driver. Eventually let the NAND manufacturer driver propose his own > + * set of timings. > + * > * After this function nand_chip->data_interface is initialized with the best > * timing mode available. > * > @@ -1079,6 +1080,10 @@ static int nand_choose_data_interface(struct nand_chip *chip) > if (!nand_controller_has_setup_data_iface(chip)) > return 0; > > + if (chip->ops.choose_data_interface) > + return chip->ops.choose_data_interface(chip, > + &chip->data_interface); > + > return nand_choose_best_sdr_timings(chip, &chip->data_interface, NULL); > } > > diff --git a/include/linux/mtd/rawnand.h b/include/linux/mtd/rawnand.h > index 2995d29587c3..5bd79e853140 100644 > --- a/include/linux/mtd/rawnand.h > +++ b/include/linux/mtd/rawnand.h > @@ -1034,6 +1034,7 @@ struct nand_legacy { > * @lock_area: Lock operation > * @unlock_area: Unlock operation > * @setup_read_retry: Set the read-retry mode (mostly needed for MLC NANDs) > + * @choose_data_interface: Choose the best data interface > */ > struct nand_chip_ops { > int (*suspend)(struct nand_chip *chip); > @@ -1041,6 +1042,8 @@ struct nand_chip_ops { > int (*lock_area)(struct nand_chip *chip, loff_t ofs, uint64_t len); > int (*unlock_area)(struct nand_chip *chip, loff_t ofs, uint64_t len); > int (*setup_read_retry)(struct nand_chip *chip, int retry_mode); > + int (*choose_data_interface)(struct nand_chip *chip, > + struct nand_data_interface *iface); > }; > > /** ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/