From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7960C433E0 for ; Tue, 26 May 2020 23:08:26 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 93BF52078C for ; Tue, 26 May 2020 23:08:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rnqrNj/7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 93BF52078C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8x68ns0a3u7DLt8mg5AHFMpzRQYRnoa/OagjTof7SZw=; b=rnqrNj/7BbwWt7 DuHBNdfTqyg3fvw86rtvFZveuoa6XaUowgIcc7zlUjCCV8cp5ceKWHGvSIXD/iNgB9Ie9aFduG0m6 elKipm5yjQrib6xvyW6Jg6aF7paxHcx5kW3rogfRp5XQnSbhOg8EaW/FDRfzwWZONwCGjXFowuxFR d85BSEK9etYC3LE9V+r3Aud63ei30XY+GuwbHWp4GkYFpr57h2UiqK1zFQoULD/8Q4jxOKD0Gfqdu m2AdgqIr9nvpi/+fS8wdjKcWQkHgPjW8OvYcump5vaEgHsz8W9p3LCn60aKXpBnPjwWo/bjSsUVUP HfcAMYNGVKptXfA9yTfw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jdigG-0007RG-7l; Tue, 26 May 2020 23:08:20 +0000 Received: from bhuna.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e3e3]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jdigD-0007Q7-JV for linux-mtd@lists.infradead.org; Tue, 26 May 2020 23:08:19 +0000 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:b93f:9fae:b276:a89a]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 36AA42A2D77; Wed, 27 May 2020 00:08:16 +0100 (BST) Date: Wed, 27 May 2020 01:08:11 +0200 From: Boris Brezillon To: Miquel Raynal Subject: Re: [RESEND v5 14/21] dt-bindings: mtd: Add the nand-ecc-placement property Message-ID: <20200527010811.5c080310@collabora.com> In-Reply-To: <20200526195633.11543-15-miquel.raynal@bootlin.com> References: <20200526195633.11543-1-miquel.raynal@bootlin.com> <20200526195633.11543-15-miquel.raynal@bootlin.com> Organization: Collabora X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200526_160817_903724_CC114EAE X-CRM114-Status: GOOD ( 18.66 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Vignesh Raghavendra , Tudor Ambarus , Richard Weinberger , Rob Herring , linux-mtd@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Tue, 26 May 2020 21:56:26 +0200 Miquel Raynal wrote: > Placement is where the ECC bytes are expected. > No value means the controller can do whatever it desires (default is > to put ECC bytes at the end of the OOB area). Alternative placement is > "interleaved" (also sometimes referred as "syndrome") where data and > OOB are mixed. Hm, unless you can figure out what all controllers use, I'd suggest to have the default mean "undefined", as in "controller put the ECC bytes somewhere, but we don't where that is". Then let the explicit values be "oob" or "interleaved". > > Signed-off-by: Miquel Raynal > --- > .../devicetree/bindings/mtd/nand-controller.yaml | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mtd/nand-controller.yaml b/Documentation/devicetree/bindings/mtd/nand-controller.yaml > index d529f8587ba6..35512f2c66fa 100644 > --- a/Documentation/devicetree/bindings/mtd/nand-controller.yaml > +++ b/Documentation/devicetree/bindings/mtd/nand-controller.yaml > @@ -56,6 +56,16 @@ patternProperties: > (Linux will handle the calculations). soft_bch is deprecated > and should be replaced by soft and nand-ecc-algo. > > + nand-ecc-placement: > + allOf: > + - $ref: /schemas/types.yaml#/definitions/string > + - enum: [ free, interleaved ] > + description: > + Location for the ECC bytes. Free is the default and means the > + controller in charge is free to put them where it wants. > + Default state is to put ECC bytes at the end of the OOB area. > + Otherwise, ECC bytes may be interleaved with data. > + > nand-ecc-algo: > allOf: > - $ref: /schemas/types.yaml#/definitions/string ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/