From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E75C0C433DF for ; Wed, 27 May 2020 07:23:03 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B8CA420C56 for ; Wed, 27 May 2020 07:23:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="oN4yww31" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B8CA420C56 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zFAD2XmbB+66G7eSXNm+xpDmLXlf8mRiQd3infAVFD8=; b=oN4yww31CdrTiG b6AD53808my/YxtI1lxYd5vDu8ndLVzdh9LTQs1KvmLiViA49eJY5Fk4iB6Y0oJdBRfZPDBBHWde1 6klZxhf3wsOSc9aEZUTUFMbhcqN/AeO4RuUnekHe43L2BTg8cO29emqIafasaPE5rsRyoIMpwv0W7 bZTVySYDWqTKbQmBmLyS4SvCUlqratbhnXhxfMsO+ELSDcltV1tqWyMi//MLKzy16lir2fmF1rvu2 B9IlO86Y6WGmRu0pKZk1NvH9r6ItiW1jzFCZuIWB2zBOWOU228PYaESsLOKQdBAPSVBJmD/PKYQmr xORIKh5VXz4DLsiktCiA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jdqOu-0007sU-OD; Wed, 27 May 2020 07:22:56 +0000 Received: from relay9-d.mail.gandi.net ([217.70.183.199]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jdqOr-0007s6-OT for linux-mtd@lists.infradead.org; Wed, 27 May 2020 07:22:55 +0000 X-Originating-IP: 91.224.148.103 Received: from xps13 (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id BE81DFF810; Wed, 27 May 2020 07:22:50 +0000 (UTC) Date: Wed, 27 May 2020 09:22:49 +0200 From: Miquel Raynal To: Boris Brezillon Subject: Re: [PATCH v5 16/28] mtd: rawnand: timings: Use default values for tPROG_max and tBERS_max Message-ID: <20200527092249.647dce05@xps13> In-Reply-To: <20200527091758.1a70aabe@xps13> References: <20200526191725.7591-1-miquel.raynal@bootlin.com> <20200526191725.7591-17-miquel.raynal@bootlin.com> <20200526232530.5c9008f1@collabora.com> <20200527091758.1a70aabe@xps13> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200527_002254_067972_E0577BC8 X-CRM114-Status: GOOD ( 23.34 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rickard Andersson , Richard Weinberger , linux-mtd@lists.infradead.org, Vignesh Raghavendra , Tudor Ambarus Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org Hi Miquel, Miquel Raynal wrote on Wed, 27 May 2020 09:17:58 +0200: > Hi Boris, > > Boris Brezillon wrote on Tue, 26 May > 2020 23:25:30 +0200: > > > On Tue, 26 May 2020 21:17:13 +0200 > > Miquel Raynal wrote: > > > > > The ONFI parameter page of a chip might define more fine grained > > > tPROG_max and tBERS_max. When we do not have this information, we > > > default to the highest possible values (they are maxima anyway). > > > > > > There is no point setting these fields at runtime, so explicitly move > > > these defaults to the main ONFI SDR timings structure. > > > > Okay, now I see why you're doing that: you want to return the mode 0 > > entry directly, and it makes sense, but it should be explained in the > > commit message. > > Okay I will mention it in the other commit message, and perhaps move > the comment about them as well so that it does not get lost. > > I can also assign these timings manually for mode 0 in the helper you > requested. Actually I don't like this idea which would mean changing the content of the timings structure itself... I would prefer to move these 4 values to the structure (as I already do) plus moving the comment explaining the derivations. > > What do you prefer? > > > > Signed-off-by: Miquel Raynal > > > --- > > > drivers/mtd/nand/raw/nand_timings.c | 24 ++++++++++++------------ > > > 1 file changed, 12 insertions(+), 12 deletions(-) > > > > > > diff --git a/drivers/mtd/nand/raw/nand_timings.c b/drivers/mtd/nand/raw/nand_timings.c > > > index c2286a75d134..52ee83e75646 100644 > > > --- a/drivers/mtd/nand/raw/nand_timings.c > > > +++ b/drivers/mtd/nand/raw/nand_timings.c > > > @@ -20,6 +20,8 @@ static const struct nand_data_interface onfi_sdr_timings[] = { > > > .timings.sdr = { > > > .tCCS_min = 500000, > > > .tR_max = 200000000, > > > + .tPROG_max = 1000000ULL * ONFI_DYN_TIMING_MAX, > > > + .tBERS_max = 1000000ULL * ONFI_DYN_TIMING_MAX, > > > .tADL_min = 400000, > > > .tALH_min = 20000, > > > .tALS_min = 50000, > > > @@ -63,6 +65,8 @@ static const struct nand_data_interface onfi_sdr_timings[] = { > > > .timings.sdr = { > > > .tCCS_min = 500000, > > > .tR_max = 200000000, > > > + .tPROG_max = 1000000ULL * ONFI_DYN_TIMING_MAX, > > > + .tBERS_max = 1000000ULL * ONFI_DYN_TIMING_MAX, > > > .tADL_min = 400000, > > > .tALH_min = 10000, > > > .tALS_min = 25000, > > > @@ -106,6 +110,8 @@ static const struct nand_data_interface onfi_sdr_timings[] = { > > > .timings.sdr = { > > > .tCCS_min = 500000, > > > .tR_max = 200000000, > > > + .tPROG_max = 1000000ULL * ONFI_DYN_TIMING_MAX, > > > + .tBERS_max = 1000000ULL * ONFI_DYN_TIMING_MAX, > > > .tADL_min = 400000, > > > .tALH_min = 10000, > > > .tALS_min = 15000, > > > @@ -149,6 +155,8 @@ static const struct nand_data_interface onfi_sdr_timings[] = { > > > .timings.sdr = { > > > .tCCS_min = 500000, > > > .tR_max = 200000000, > > > + .tPROG_max = 1000000ULL * ONFI_DYN_TIMING_MAX, > > > + .tBERS_max = 1000000ULL * ONFI_DYN_TIMING_MAX, > > > .tADL_min = 400000, > > > .tALH_min = 5000, > > > .tALS_min = 10000, > > > @@ -192,6 +200,8 @@ static const struct nand_data_interface onfi_sdr_timings[] = { > > > .timings.sdr = { > > > .tCCS_min = 500000, > > > .tR_max = 200000000, > > > + .tPROG_max = 1000000ULL * ONFI_DYN_TIMING_MAX, > > > + .tBERS_max = 1000000ULL * ONFI_DYN_TIMING_MAX, > > > .tADL_min = 400000, > > > .tALH_min = 5000, > > > .tALS_min = 10000, > > > @@ -235,6 +245,8 @@ static const struct nand_data_interface onfi_sdr_timings[] = { > > > .timings.sdr = { > > > .tCCS_min = 500000, > > > .tR_max = 200000000, > > > + .tPROG_max = 1000000ULL * ONFI_DYN_TIMING_MAX, > > > + .tBERS_max = 1000000ULL * ONFI_DYN_TIMING_MAX, > > > .tADL_min = 400000, > > > .tALH_min = 5000, > > > .tALS_min = 10000, > > > @@ -359,18 +371,6 @@ int onfi_fill_data_interface(struct nand_chip *chip, > > > > > > /* nanoseconds -> picoseconds */ > > > timings->tCCS_min = 1000UL * onfi->tCCS; > > > - } else { > > > - struct nand_sdr_timings *timings = &iface->timings.sdr; > > > - /* > > > - * For non-ONFI chips we use the highest possible value for > > > - * tPROG and tBERS. tR and tCCS will take the default values > > > - * precised in the ONFI specification for timing mode 0, > > > - * respectively 200us and 500ns. > > > - */ > > > - > > > - /* microseconds -> picoseconds */ > > > - timings->tPROG_max = 1000000ULL * ONFI_DYN_TIMING_MAX; > > > - timings->tBERS_max = 1000000ULL * ONFI_DYN_TIMING_MAX; > > > } > > > > > > return 0; > > ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/