From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E38B3C433DF for ; Wed, 27 May 2020 08:14:45 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B68FE21531 for ; Wed, 27 May 2020 08:14:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="BKCZCFkQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B68FE21531 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=q8Q3kn0YtdSVACMQVvuG2FUPi/pju9PUp/8YSo4QRVg=; b=BKCZCFkQWU3x+4 NhdpQJiM2+1FyB5sqKdrV6XGYwZQ+0En94DpHqBM+uo7polx4q/F3yyQSQvP2Gy8KtwV4zsSlIP+6 TWnkkmnP3+uTWdk1ZbMUDmPJRTMGtnUBJmDtLzwfdmuyiTqiQrWFc85gzMEBvzRbqdkc0KYllMK7W BjWy6WeTySHwIhU7+/GdmZNzkwTDSrEjf4PwYVdG3HExORABkl4Q+/Qxmf0Gymxd+mOYLB8/dA0d1 7a4zIndZsNfmzp64YOi9JnG6ymwEipy5b5ZFK5fVTonB9MD6fUyJJfesBryUa9GyTdmDELbhYp0KU lq/dyDLd5Zfkfebe+1RA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jdrCt-0003UU-8J; Wed, 27 May 2020 08:14:35 +0000 Received: from bhuna.collabora.co.uk ([46.235.227.227]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jdrCo-0003Ti-CM for linux-mtd@lists.infradead.org; Wed, 27 May 2020 08:14:31 +0000 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id E91F72A0489; Wed, 27 May 2020 09:14:28 +0100 (BST) Date: Wed, 27 May 2020 10:14:26 +0200 From: Boris Brezillon To: Miquel Raynal Subject: Re: [PATCH v5 20/28] mtd: rawnand: Hide the chip->data_interface indirection Message-ID: <20200527101426.04d84cb9@collabora.com> In-Reply-To: <20200527093603.704c6891@xps13> References: <20200526191725.7591-1-miquel.raynal@bootlin.com> <20200526191725.7591-21-miquel.raynal@bootlin.com> <20200526233620.44914f1f@collabora.com> <20200527093603.704c6891@xps13> Organization: Collabora X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200527_011430_548003_367DD7E5 X-CRM114-Status: GOOD ( 19.99 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rickard Andersson , Richard Weinberger , Vignesh Raghavendra , Tudor Ambarus Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Wed, 27 May 2020 09:36:03 +0200 Miquel Raynal wrote: > Hi Boris, > > Boris Brezillon wrote on Tue, 26 May > 2020 23:36:20 +0200: > > > On Tue, 26 May 2020 21:17:17 +0200 > > Miquel Raynal wrote: > > > > > As a preparation for allocating the data interface structure > > > dynamically (and rename it), let's avoid calling it directly. > > > > > > Instead, we operate a rename on an existing helper to reuse that name > > > for another helper: > > > * s/nand_get_sdr_timings/nand_extract_sdr_timings/ > > > -> this helper just extracts timings from a given data interface > > > > Hm, I'm not entirely happy with that name. In my mind extract means > > that you had to do some transformation to get the data, which is not > > the case here. How about nand_data_interface_get_sdr_timings()? > > > > > * nand_get_sdr_timings() > > > -> this helper retrieves the in use timings from a nand_chip structure > > > > Do we really need that one? Can we do that in 2 steps instead? > > Yes I can do that in two steps, I didn't think it was needed but no pb. > > > > > conf = nand_get_data_interface_config(chip); > > sdr = nand_data_interface_get_sdr_timings(conf); > > I find the names too long. Do you think I can stick to > nand_get_sdr_timings(conf) and nand_get_data_interface(chip)? These > helpers are very often used at the start of a function and would > definitely break systematically the 80 chars limit otherwise... Could be nand_get_interface_config() (see my rename patch) and nand_get_sdr_timings(), yes. ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/