From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1C61C433E0 for ; Thu, 28 May 2020 12:09:19 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 539E221548 for ; Thu, 28 May 2020 12:09:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="gr9nZ7Nu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 539E221548 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Ykpo78zW/kIaB9cX4k0roUH7fUcgI0qCXWiqdBNP2Vw=; b=gr9nZ7Nu1+Rm3V r/vm5Xsx5Lo8ez8DIJOArGJvkCnf34wHjpO0kaz/RMV1qiPQhXHKQ+osZLTnPLNLvh0VDsDBCdi+2 vZJ1h6PEwWrby61SlVGhrmzDOyFbjvlAHWAGzjW3kTcFoSfxdsXpeciplhPV/ep4izmJRK9XrfgZl PT8Q20Am2EMEEdJEerKAhDNe4ajzkGaObQz2NNcTj2S2qpoBcW0MT5KLWBkD15TLWDxbwzF7jHWaN nO5L/2hajiq+5chF5XOl6r/YpwhKN+B18UgtfRrO90heDaGtOUCB75OOyGHLv+J/lRQG2LO8aTs1t rNuOWsLZ1SXHBKEnw0AA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jeHLR-0003L1-Nf; Thu, 28 May 2020 12:09:09 +0000 Received: from bhuna.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e3e3]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jeHLF-0003AI-Id; Thu, 28 May 2020 12:08:58 +0000 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 9E32A2A2E33; Thu, 28 May 2020 13:08:55 +0100 (BST) Date: Thu, 28 May 2020 14:08:52 +0200 From: Boris Brezillon To: Miquel Raynal Subject: Re: [PATCH v6 02/18] mtd: rawnand: Create a new enumeration to describe OOB placement Message-ID: <20200528140852.51f19794@collabora.com> In-Reply-To: <20200528113113.9166-3-miquel.raynal@bootlin.com> References: <20200528113113.9166-1-miquel.raynal@bootlin.com> <20200528113113.9166-3-miquel.raynal@bootlin.com> Organization: Collabora X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200528_050857_744355_BA8E32BF X-CRM114-Status: GOOD ( 17.71 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Vignesh Raghavendra , Tudor Ambarus , Julien Su , Richard Weinberger , Weijie Gao , Paul Cercueil , Rob Herring , linux-mtd@lists.infradead.org, Thomas Petazzoni , Mason Yang , Chuanhong Guo , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Thu, 28 May 2020 13:30:57 +0200 Miquel Raynal wrote: In the subject s/OOB placement/ECC placement/ > There is currently a confusion between the ECC type/mode/provider > (eg. on-host, software, on-die or none) and the ECC bytes placement. > > Create a new enumeration to describe this placement. > > Signed-off-by: Miquel Raynal > Reviewed-by: Boris Brezillon > --- > drivers/mtd/nand/raw/nand_base.c | 5 +++++ > include/linux/mtd/rawnand.h | 14 ++++++++++++++ > 2 files changed, 19 insertions(+) > > diff --git a/drivers/mtd/nand/raw/nand_base.c b/drivers/mtd/nand/raw/nand_base.c > index bd3f5a875e39..4d2d444f9db9 100644 > --- a/drivers/mtd/nand/raw/nand_base.c > +++ b/drivers/mtd/nand/raw/nand_base.c > @@ -5018,6 +5018,11 @@ static const char * const nand_ecc_modes[] = { > [NAND_ECC_ON_DIE] = "on-die", > }; > > +static const char * const nand_ecc_placement[] = { > + [NAND_ECC_PLACEMENT_OOB] = "oob", > + [NAND_ECC_PLACEMENT_INTERLEAVED] = "interleaved", > +}; > + > static int of_get_nand_ecc_mode(struct device_node *np) > { > const char *pm; > diff --git a/include/linux/mtd/rawnand.h b/include/linux/mtd/rawnand.h > index 65b1c1c18b41..5e014807e050 100644 > --- a/include/linux/mtd/rawnand.h > +++ b/include/linux/mtd/rawnand.h > @@ -92,6 +92,20 @@ enum nand_ecc_mode { > NAND_ECC_ON_DIE, > }; > > +/** > + * enum nand_ecc_placement - NAND ECC bytes placement > + * @NAND_ECC_PLACEMENT_UNKNOWN: The actual position of the ECC bytes is unknown > + * @NAND_ECC_PLACEMENT_OOB: The ECC bytes are located in the OOB area > + * @NAND_ECC_PLACEMENT_INTERLEAVED: Syndrome layout, there are ECC bytes > + * interleaved with regular data in the main > + * area > + */ > +enum nand_ecc_placement { > + NAND_ECC_PLACEMENT_UNKNOWN, > + NAND_ECC_PLACEMENT_OOB, > + NAND_ECC_PLACEMENT_INTERLEAVED, > +}; > + > enum nand_ecc_algo { > NAND_ECC_UNKNOWN, > NAND_ECC_HAMMING, ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/