From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52AA3C433DF for ; Thu, 28 May 2020 14:46:09 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2867120814 for ; Thu, 28 May 2020 14:46:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="mn46yTu/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2867120814 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1kUTaaj/Ql89VyUqnA1QGeLuhne6LiCIRJ8x/0sBw5U=; b=mn46yTu/9Bf5/4 f0aCvvX6xKXTuIitq8UlfnFEdZ4LOTtrGZXJnpUVvyq+GHgjqV+n1pJXLRTL0FFeeF4b8+4pJmJ70 3UjJcwz/fnrsHzRDV71kAhiQvmmSmPcfx8SLafj70fbh98lY+Dk+npDOw4FpIAy3o2kGAglOM4zt5 yU9jJOSXtIh7vKNA8MIRt0qqDLKw8J10G3tfZuZOZZd5FiWoYeyN4noTJTcUci1bx7Ei7WNE829Ry RLsqhU5Euz03dPxMVHizt0qYivTxhKlj49WcH2pBLSAXy3cX6nbDyWN8dbvDdqPCsbr2NvjC3TVxH ErB34nXYgnMXHTxngyYA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jeJnF-0000u4-PT; Thu, 28 May 2020 14:46:01 +0000 Received: from relay6-d.mail.gandi.net ([217.70.183.198]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jeJmy-0000jO-CV; Thu, 28 May 2020 14:45:45 +0000 X-Originating-IP: 91.224.148.103 Received: from xps13 (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 4C0F4C0009; Thu, 28 May 2020 14:45:37 +0000 (UTC) Date: Thu, 28 May 2020 16:45:35 +0200 From: Miquel Raynal To: Boris Brezillon Subject: Re: [PATCH v6 08/18] mtd: rawnand: Use the new ECC engine type enumeration Message-ID: <20200528164535.3655ffcb@xps13> In-Reply-To: <20200528163150.6ad71fcc@collabora.com> References: <20200528113113.9166-1-miquel.raynal@bootlin.com> <20200528113113.9166-9-miquel.raynal@bootlin.com> <20200528163150.6ad71fcc@collabora.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200528_074544_556666_96E2E605 X-CRM114-Status: GOOD ( 17.60 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Vignesh Raghavendra , Tudor Ambarus , Julien Su , Richard Weinberger , Weijie Gao , Paul Cercueil , Rob Herring , linux-mtd@lists.infradead.org, Thomas Petazzoni , Mason Yang , Chuanhong Guo , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org Boris Brezillon wrote on Thu, 28 May 2020 16:31:50 +0200: > On Thu, 28 May 2020 13:31:03 +0200 > Miquel Raynal wrote: > > > Mechanical switch from the legacy "mode" enumeration to the new > > "engine type" enumeration in drivers and board files. > > > > The device tree parsing is also updated to return the new enumeration > > from the old strings. > > > > Signed-off-by: Miquel Raynal > > I didn't check all the changes, but I'm fine with the approach > > Reviewed-by: Boris Brezillon > > > diff --git a/include/linux/platform_data/mtd-davinci.h b/include/linux/platform_data/mtd-davinci.h > > index 3383101c233b..dd474dd44848 100644 > > --- a/include/linux/platform_data/mtd-davinci.h > > +++ b/include/linux/platform_data/mtd-davinci.h > > @@ -60,16 +60,16 @@ struct davinci_nand_pdata { /* platform_data */ > > struct mtd_partition *parts; > > unsigned nr_parts; > > > > - /* none == NAND_ECC_NONE (strongly *not* advised!!) > > - * soft == NAND_ECC_SOFT > > - * else == NAND_ECC_HW, according to ecc_bits > > + /* none == NAND_ECC_ENGINE_TYPE_NONE (strongly *not* advised!!) > > + * soft == NAND_ECC_ENGINE_TYPE_SOFT > > + * else == NAND_ECC_ENGINE_TYPE_ON_HOST, according to ecc_bits > > * > > * All DaVinci-family chips support 1-bit hardware ECC. > > * Newer ones also support 4-bit ECC, but are awkward > > * using it with large page chips. > > */ > > - enum nand_ecc_mode ecc_mode; > > - enum nand_ecc_placement ecc_placement; > > + enum nand_ecc_engine_type engine_type; > > + enum nand_ecc_placement ecc_placement; > > Nitpick: if you want to use a space instead of tab, it should be done in > patch 3. Right, fixed! ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/