From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24E5BC433DF for ; Thu, 28 May 2020 23:55:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E8D76206DF for ; Thu, 28 May 2020 23:55:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Gaug/EhW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E8D76206DF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=T0L2TgwdLSf1mMwrMtyBpWfzEmMYnNitsUXOQekaZJo=; b=Gaug/EhW4Pqkqg BTszPqeFZiy6XFuGRa3td8hUa76mYotepLF6M1nAYmCTnmuHlyj5aAiuRDQn7oi7pShNDnvQvqM+a L/klQQH4t8frAJzhsOg3Eum3YMbsElaNl1URTyc2mjcQM1V6AVm/8uXqTxGLziLRryXwzt9btFliE v7oVY0ygmKPL9/nAWhGQQ3HYP2hiSd5qvPKHv0jHSoqRp4B/jYNhgU9YhNY3wOC6+XW8OR0d7hr4g yxIzY/L32/yY5xUPGCMvH7Q+rLUWQd6eBRFIlYu9zJIPdQyRWEu1OHUHjiR03hCi709xWunuM6fFT 7dRNRymt3vPlySN6coLw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jeSNA-00056E-Q1; Thu, 28 May 2020 23:55:40 +0000 Received: from relay7-d.mail.gandi.net ([217.70.183.200]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jeSMx-0004t1-Of; Thu, 28 May 2020 23:55:29 +0000 X-Originating-IP: 91.224.148.103 Received: from xps13 (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id ED71F20003; Thu, 28 May 2020 23:55:20 +0000 (UTC) Date: Fri, 29 May 2020 01:55:19 +0200 From: Miquel Raynal To: Boris Brezillon Subject: Re: [PATCH v6 18/18] mtd: rawnand: Move generic bits to the ECC framework Message-ID: <20200529015519.14ee29be@xps13> In-Reply-To: <20200528175656.0a32dd7c@collabora.com> References: <20200528113113.9166-1-miquel.raynal@bootlin.com> <20200528113113.9166-19-miquel.raynal@bootlin.com> <20200528175656.0a32dd7c@collabora.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200528_165527_938319_43D7581D X-CRM114-Status: GOOD ( 11.36 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Vignesh Raghavendra , Tudor Ambarus , Julien Su , Richard Weinberger , Weijie Gao , Paul Cercueil , Rob Herring , linux-mtd@lists.infradead.org, Thomas Petazzoni , Mason Yang , Chuanhong Guo , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org Boris Brezillon wrote on Thu, 28 May 2020 17:56:56 +0200: > On Thu, 28 May 2020 13:31:13 +0200 > Miquel Raynal wrote: > > > +/** > > + * nanddev_get_flash_node() - Get the device node attached to a NAND device > > + * @nand: NAND device > > + * > > + * Return: the device node linked to @nand. > > + */ > > +static inline struct device_node *nanddev_get_flash_node(struct nand_device *nand) > > +{ > > + return mtd_get_of_node(nanddev_to_mtd(nand)); > > +} > > + > > Can we name that one nanddev_get_of_node(). We'll probably want to > expose fwnode at some point, and get_flash_node() is a bit too generic > IMO. I just spot that there is a nanddev_get_of_node() function already, which does exactly the same as nanddev_get_flash_node(), so I just dropped it. ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/