From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 180ADC433E0 for ; Fri, 29 May 2020 11:25:41 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D569920721 for ; Fri, 29 May 2020 11:25:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="blP/vuHk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D569920721 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HXnOtDTF5LafRnNLAsbTqkZXk6AXvmTYjazyPGKcfr0=; b=blP/vuHk5Cv0m5 mWizZon2laqZ5Sbc9wbtnEuAR/+ZNhtvwmZ5taJJfKQurPMCAa8JXC7sJNVng/RYCtzBRe/10iF5+ lFHccTV4AfYb4H0BM2j4iYVkLb9ZoU5Rd7LrwmaZGDqPTN527/QZRpBKw/+R7XaNsZhxtn11ZytRz i2FHNj94ztDZJdElbrE2eiKxi7sumuCa0q5XLYPR4NesNqM0TYC+O5+7jxT+rEhh3LPAR8Rj01hRH 6viFJ2KBQW+ZAQ9LybTPB1ry6m5IO2K0P8aqusXQDOfmsuFqRGQ2tX9hJODxfDtEF5ptLMNx4n5L6 s0A6iDF34brZbxVHcizw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jed8m-00028S-7Y; Fri, 29 May 2020 11:25:32 +0000 Received: from bhuna.collabora.co.uk ([46.235.227.227]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jed8j-000266-S2 for linux-mtd@lists.infradead.org; Fri, 29 May 2020 11:25:31 +0000 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id E30122A4319; Fri, 29 May 2020 12:25:27 +0100 (BST) Date: Fri, 29 May 2020 13:25:25 +0200 From: Boris Brezillon To: Miquel Raynal Subject: Re: [PATCH v7 16/28] mtd: rawnand: timings: Avoid redefining tR_max and tCCS_min Message-ID: <20200529132525.454d1054@collabora.com> In-Reply-To: <20200529111322.7184-17-miquel.raynal@bootlin.com> References: <20200529111322.7184-1-miquel.raynal@bootlin.com> <20200529111322.7184-17-miquel.raynal@bootlin.com> Organization: Collabora X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200529_042530_035300_02901F50 X-CRM114-Status: GOOD ( 14.90 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michal Simek , Vignesh Raghavendra , Tudor Ambarus , Richard Weinberger , Naga Sureshkumar Relli , Thomas Petazzoni , linux-mtd@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Fri, 29 May 2020 13:13:10 +0200 Miquel Raynal wrote: > These two values are already hardcoded in the default ONFI timing > structure, no need to redefine them here. Plus, we want to be able to > reference timing mode 0 easily and reliably, without extra > computation, so we get rid of the extra assignations. > > Signed-off-by: Miquel Raynal Reviewed-by: Boris Brezillon > --- > drivers/mtd/nand/raw/nand_timings.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/mtd/nand/raw/nand_timings.c b/drivers/mtd/nand/raw/nand_timings.c > index b089f2dc5f23..54c7a1a8b038 100644 > --- a/drivers/mtd/nand/raw/nand_timings.c > +++ b/drivers/mtd/nand/raw/nand_timings.c > @@ -369,9 +369,6 @@ int onfi_fill_data_interface(struct nand_chip *chip, > /* microseconds -> picoseconds */ > timings->tPROG_max = 1000000ULL * ONFI_DYN_TIMING_MAX; > timings->tBERS_max = 1000000ULL * ONFI_DYN_TIMING_MAX; > - > - timings->tR_max = 200000000; > - timings->tCCS_min = 500000; > } > > return 0; ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/