From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 439A3C433E0 for ; Fri, 29 May 2020 11:28:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 134362074D for ; Fri, 29 May 2020 11:28:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Yz0Nty43" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 134362074D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mAb/+EHqvmxghPF0PlEcuHkzcirvsqmIG7ItVa8Dkls=; b=Yz0Nty43PJ9hH3 Uh/NuWwRlhh/yFgodIU5PhMji2vkLeeha+J6D4PpArlJlXtKLJSNvXxbIQaHExDZJGiX6NsrDaZRB H42TrSAxnuiZq5EgA2x5iVrXlLt9QlK94EGDUZL6diEhc2cqTZ5GiIKAP2ICpBS8oEZ+iQpA8vNyR tY2gPyTRG0utY2p8Wp9roVqNBcrRc0NI2H0b3r00cvPc9LzjPwJ0cSCSMVuj1qTdctlZ9mBDScugz ITUpYDCN6k/olzWwMra8G9tV/T72QZ9EkycwAhAEKe4WrSK0/tyysmcsHLztRmda4fjlI5nvcliX8 DGctaBfWMCUhz/YgUj0g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jedBJ-0002uk-K4; Fri, 29 May 2020 11:28:09 +0000 Received: from bhuna.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e3e3]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jedBG-0002uM-O3 for linux-mtd@lists.infradead.org; Fri, 29 May 2020 11:28:08 +0000 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 123E52A433F; Fri, 29 May 2020 12:28:04 +0100 (BST) Date: Fri, 29 May 2020 13:28:01 +0200 From: Boris Brezillon To: Miquel Raynal Subject: Re: [PATCH v7 14/28] mtd: rawnand: timings: onfi_fill_data_interface timing mode is unsigned Message-ID: <20200529132801.65d04b08@collabora.com> In-Reply-To: <20200529111322.7184-15-miquel.raynal@bootlin.com> References: <20200529111322.7184-1-miquel.raynal@bootlin.com> <20200529111322.7184-15-miquel.raynal@bootlin.com> Organization: Collabora X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200529_042806_915371_05C7BE10 X-CRM114-Status: GOOD ( 16.81 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michal Simek , Vignesh Raghavendra , Tudor Ambarus , Richard Weinberger , Naga Sureshkumar Relli , Thomas Petazzoni , linux-mtd@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Fri, 29 May 2020 13:13:08 +0200 Miquel Raynal wrote: > Turn this argument into an unsigned int, as it cannot be signed. This > also spares a check. > > Signed-off-by: Miquel Raynal Reviewed-by: Boris Brezillon > --- > drivers/mtd/nand/raw/internals.h | 2 +- > drivers/mtd/nand/raw/nand_timings.c | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/mtd/nand/raw/internals.h b/drivers/mtd/nand/raw/internals.h > index 0f74509abc4c..bd10ec92f04a 100644 > --- a/drivers/mtd/nand/raw/internals.h > +++ b/drivers/mtd/nand/raw/internals.h > @@ -87,7 +87,7 @@ int nand_erase_nand(struct nand_chip *chip, struct erase_info *instr, > int onfi_fill_data_interface(struct nand_chip *chip, > struct nand_data_interface *iface, > enum nand_data_interface_type type, > - int timing_mode); > + unsigned int timing_mode); > int nand_get_features(struct nand_chip *chip, int addr, u8 *subfeature_param); > int nand_set_features(struct nand_chip *chip, int addr, u8 *subfeature_param); > int nand_read_page_raw_notsupp(struct nand_chip *chip, u8 *buf, > diff --git a/drivers/mtd/nand/raw/nand_timings.c b/drivers/mtd/nand/raw/nand_timings.c > index ce6bb87db2e8..08dc381349fa 100644 > --- a/drivers/mtd/nand/raw/nand_timings.c > +++ b/drivers/mtd/nand/raw/nand_timings.c > @@ -283,14 +283,14 @@ static const struct nand_data_interface onfi_sdr_timings[] = { > int onfi_fill_data_interface(struct nand_chip *chip, > struct nand_data_interface *iface, > enum nand_data_interface_type type, > - int timing_mode) > + unsigned int timing_mode) > { > struct onfi_params *onfi = chip->parameters.onfi; > > if (type != NAND_SDR_IFACE) > return -EINVAL; > > - if (timing_mode < 0 || timing_mode >= ARRAY_SIZE(onfi_sdr_timings)) > + if (timing_mode >= ARRAY_SIZE(onfi_sdr_timings)) > return -EINVAL; > > *iface = onfi_sdr_timings[timing_mode]; ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/