From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE5EEC433E0 for ; Wed, 3 Jun 2020 10:30:36 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BBD4720674 for ; Wed, 3 Jun 2020 10:30:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="uFJfThM5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BBD4720674 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=m4DE/JVrEKlIc+ryCbusBiE5gxoLTAaOU4lXHsryPf8=; b=uFJfThM5OQhxBC DD/lVvQ6462bgd5GpRqIOyHPDtlzrFvICC0J0LYiYzbyCdDBe4fxw1/SVfhSQxm/KVfkaU3X33Yh9 RpOvip3hH48VqgqMq1lRs+atsDVz5VzIPK6GsfRlzUg4jyznoAFsozheU12D/7tYZd/zwi4w4OeP1 q+bhmgR27vw7bLl28C+++FeTSsDPSLStnzaVrrJ442uhhCDVcVaMyAPrOQNFPBhZiuB8ViP6/EFYn nQXrq8QDd2ivDxcvbsqlIcE0gLOzOHuwo2aVEf2tT4AoQ2QlvUwc3f8e4C2JmWHi4+CuEMJvQwVOT 3ai+eKYf1X3rcMgn5tfw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jgQf7-0000My-5J; Wed, 03 Jun 2020 10:30:21 +0000 Received: from relay7-d.mail.gandi.net ([217.70.183.200]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jgQen-0006G1-15; Wed, 03 Jun 2020 10:30:02 +0000 X-Originating-IP: 91.224.148.103 Received: from xps13 (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 9740E20007; Wed, 3 Jun 2020 10:29:53 +0000 (UTC) Date: Wed, 3 Jun 2020 12:29:51 +0200 From: Miquel Raynal To: Boris Brezillon Subject: Re: [PATCH v9 5/9] mtd: nand: Convert generic NAND bits to use the ECC framework Message-ID: <20200603122951.75fb8e6f@xps13> In-Reply-To: <20200602180320.6539adb0@collabora.com> References: <20200602143124.29553-1-miquel.raynal@bootlin.com> <20200602143124.29553-6-miquel.raynal@bootlin.com> <20200602180320.6539adb0@collabora.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200603_033001_202422_C5655971 X-CRM114-Status: GOOD ( 13.85 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vignesh Raghavendra , Tudor Ambarus , Julien Su , Richard Weinberger , linux-mtd@lists.infradead.org, Thomas Petazzoni , Mason Yang , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org Boris Brezillon wrote on Tue, 2 Jun 2020 18:03:20 +0200: > On Tue, 2 Jun 2020 16:31:20 +0200 > Miquel Raynal wrote: > > > Embed a generic NAND ECC high-level object in the nand_device > > structure to carry all the ECC engine configuration/data. > > > > Signed-off-by: Miquel Raynal > > --- > > drivers/mtd/nand/raw/nand_base.c | 4 +++- > > include/linux/mtd/nand.h | 12 ++++++------ > > 2 files changed, 9 insertions(+), 7 deletions(-) > > > > diff --git a/drivers/mtd/nand/raw/nand_base.c b/drivers/mtd/nand/raw/nand_base.c > > index e8e22d79f422..ed0f642be993 100644 > > --- a/drivers/mtd/nand/raw/nand_base.c > > +++ b/drivers/mtd/nand/raw/nand_base.c > > @@ -5984,7 +5984,9 @@ static int nand_scan_tail(struct nand_chip *chip) > > /* ECC sanity check: warn if it's too weak */ > > if (!nand_ecc_strength_good(chip)) > > pr_warn("WARNING: %s: the ECC used on your system (%db/%dB) is too weak compared to the one required by the NAND chip (%db/%dB)\n", > > - mtd->name, chip->ecc.strength, chip->ecc.size, > > + mtd->name, > > + nanddev_get_ecc_conf(&chip->base)->strength, > > + nanddev_get_ecc_conf(&chip->base)->step_size, > > Hm, are you sure all places using chip->ecc.{strength,size} have been > patched to use nanddev_get_ecc_conf()? Not yet, I thought I removed this change but apparently not. I will drop this. ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/