From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21835C433DF for ; Wed, 3 Jun 2020 12:59:07 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E986E206C3 for ; Wed, 3 Jun 2020 12:59:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="SVjkdEUG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E986E206C3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Q/rCi8jNUmj7P4cdidfozClQMXTU3eQX6en+GgdXW/g=; b=SVjkdEUGvwQIvf ZVgzMUDgqaglwPN3HXrWQaVcX3oxk/Qes6qnfdwJOuZZgOpnzdlAIEl3BIbx8HspT9XPqcl3ZirJD Nb0gqtBVbCU7hZCVv5Y2KLab2Xw7k1dzqVBBpteV3BbxGLzvKZL4C16Db34rWDFZ0JsGLJSP9bzgt qPy+6KfXxMe9vskYY8tMN9Qgq8fO1arQFUDRGn/xLsOkNBXX2Dx/H4iwtTq6EMuOr8JOkRLjMYfcK HSmLtdT5tBsIqz0xGaREtcYtfQJUL/thQbp+AcB9Hur4tdQGpnB0DMgmCS0r8k3CXfZsQRabJpTFZ fS+8k7vzXFeN4l0ctqJw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jgSyr-0000ty-CL; Wed, 03 Jun 2020 12:58:53 +0000 Received: from relay12.mail.gandi.net ([217.70.178.232]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jgSye-0000gw-79; Wed, 03 Jun 2020 12:58:41 +0000 Received: from xps13 (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 0AC86200010; Wed, 3 Jun 2020 12:58:34 +0000 (UTC) Date: Wed, 3 Jun 2020 14:58:33 +0200 From: Miquel Raynal To: Boris Brezillon Subject: Re: [PATCH v9 9/9] mtd: rawnand: Move the user input parsing bits to the ECC framework Message-ID: <20200603145833.3f80ef6d@xps13> In-Reply-To: <20200602182157.26716f89@collabora.com> References: <20200602143124.29553-1-miquel.raynal@bootlin.com> <20200602143124.29553-10-miquel.raynal@bootlin.com> <20200602182157.26716f89@collabora.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200603_055840_388991_7BA5AEEB X-CRM114-Status: UNSURE ( 7.64 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vignesh Raghavendra , Tudor Ambarus , Julien Su , Richard Weinberger , linux-mtd@lists.infradead.org, Thomas Petazzoni , Mason Yang , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org Boris Brezillon wrote on Tue, 2 Jun 2020 18:21:57 +0200: > On Tue, 2 Jun 2020 16:31:24 +0200 > Miquel Raynal wrote: > > > +void nand_ecc_read_user_conf(struct nand_device *nand) > > This function is not introduced in this patch, but I'm commenting here. > Looks like it only operates on an OF node, so how about naming it > of_get_nand_ecc_config(). of_get_nand_ecc_user_config()? I'd like to mention "user" because "config" is way too vague given the number of possible configuration sources. ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/