From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C8D5C2D0E2 for ; Tue, 22 Sep 2020 08:45:28 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 042FA2085B for ; Tue, 22 Sep 2020 08:45:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="xjaiwdi9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 042FA2085B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=L98A1TsMeoLQM65VqIA8tVAssIOPaNoA0x1b8KSII+M=; b=xjaiwdi9HaG5N9MN+jdCERdw7 70djQH0NwszroeMDbRBB5s0K9iwcAAo0cHSnkjk92Msp+6cgl/qOxidjsGAzXoztvMXc15b++fNe5 ItSoh9MHsh1yV9Q1vgo8QSpdQ2sFlNdysvFIcSdDqtjK53FhgEriFwSS/9T9zeZ7awVYCEc32VaCW TQnQJT/noWylN5PHZMPAgiO0ySQuHEa421j7SQcyEB0z+A1TLdEwfkF+oNgHKTFq1ogTnS+Y3N+Q3 1Li4crLEP86U0ZWECNe9fBc23f1NLgLDIBPu2nswnsklJIJVLeJ7Qx1sJYvpUjkD0KXr7hf5RQUix O1yL6L1RA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kKdue-0000ou-N8; Tue, 22 Sep 2020 08:44:36 +0000 Received: from mx2.suse.de ([195.135.220.15]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kKdub-0000nq-5g for linux-mtd@lists.infradead.org; Tue, 22 Sep 2020 08:44:34 +0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id AC920ACBF; Tue, 22 Sep 2020 08:45:08 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id 7FB371E12E3; Tue, 22 Sep 2020 10:44:31 +0200 (CEST) Date: Tue, 22 Sep 2020 10:44:31 +0200 From: Jan Kara To: Christoph Hellwig Subject: Re: [PATCH 03/13] bcache: inherit the optimal I/O size Message-ID: <20200922084431.GA16464@quack2.suse.cz> References: <20200921080734.452759-1-hch@lst.de> <20200921080734.452759-4-hch@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200921080734.452759-4-hch@lst.de> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200922_044433_418656_6AC3C74F X-CRM114-Status: GOOD ( 18.90 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jens Axboe , linux-raid@vger.kernel.org, Hans de Goede , Justin Sanders , Minchan Kim , Richard Weinberger , linux-bcache@vger.kernel.org, Coly Li , linux-block@vger.kernel.org, Song Liu , dm-devel@redhat.com, linux-mtd@lists.infradead.org, Johannes Thumshirn , linux-fsdevel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, drbd-dev@lists.linbit.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Mon 21-09-20 10:07:24, Christoph Hellwig wrote: > Inherit the optimal I/O size setting just like the readahead window, > as any reason to do larger I/O does not apply to just readahead. > > Signed-off-by: Christoph Hellwig The patch looks good to me. You can add: Reviewed-by: Jan Kara Honza > --- > drivers/md/bcache/super.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c > index 1bbdc410ee3c51..48113005ed86ad 100644 > --- a/drivers/md/bcache/super.c > +++ b/drivers/md/bcache/super.c > @@ -1430,6 +1430,8 @@ static int cached_dev_init(struct cached_dev *dc, unsigned int block_size) > dc->disk.disk->queue->backing_dev_info->ra_pages = > max(dc->disk.disk->queue->backing_dev_info->ra_pages, > q->backing_dev_info->ra_pages); > + blk_queue_io_opt(dc->disk.disk->queue, > + max(queue_io_opt(dc->disk.disk->queue), queue_io_opt(q))); > > atomic_set(&dc->io_errors, 0); > dc->io_disable = false; > -- > 2.28.0 > -- Jan Kara SUSE Labs, CR ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/