From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2869BC2D0E2 for ; Tue, 22 Sep 2020 08:45:55 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BAB8522206 for ; Tue, 22 Sep 2020 08:45:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ot9CsedW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BAB8522206 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ttxr0lRGruecIsM1SKjrBN3jPdS4v/FjY46Fn6MWHcc=; b=ot9CsedW1U/ncFG1CFAk3FZza E/Oow2c+ZYVnGZuthoINWFn7cx9HR9gXwkXRqCPw/fc3O2Xx77WrrYzVp8Xw0x9Z+QjD3jkYss3/J juxfnyElyoojyzrxlUTWuHsV3eBB56c18yZUc/NREiOy2MHIDw9vCSf8MNUvkps65AZlP2BSg3J3B tw8rH0DKs6bPy3v3F9LfdurWUVFkNX+MW6t1N7tITgHdZ+EaMdqBXNAeajfAoFKX30JfTHAouyc/v Yh6T/Zqb+dcZgG4rvo+amP5ItkY5zJUfeZZ/ogl2yhbkOUoVigJGWtFraL7qeVJiMtC+3rFb2sjBJ NahC6Zvdg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kKdvS-0000uO-75; Tue, 22 Sep 2020 08:45:26 +0000 Received: from mx2.suse.de ([195.135.220.15]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kKdvL-0000te-3l for linux-mtd@lists.infradead.org; Tue, 22 Sep 2020 08:45:19 +0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id B80B1AEEF; Tue, 22 Sep 2020 08:45:54 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id ED14B1E12E3; Tue, 22 Sep 2020 10:45:17 +0200 (CEST) Date: Tue, 22 Sep 2020 10:45:17 +0200 From: Jan Kara To: Christoph Hellwig Subject: Re: [PATCH 04/13] aoe: set an optimal I/O size Message-ID: <20200922084517.GB16464@quack2.suse.cz> References: <20200921080734.452759-1-hch@lst.de> <20200921080734.452759-5-hch@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200921080734.452759-5-hch@lst.de> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200922_044519_291709_37134E25 X-CRM114-Status: GOOD ( 19.12 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jens Axboe , linux-raid@vger.kernel.org, Hans de Goede , Justin Sanders , Minchan Kim , Richard Weinberger , linux-bcache@vger.kernel.org, Coly Li , linux-block@vger.kernel.org, Song Liu , dm-devel@redhat.com, linux-mtd@lists.infradead.org, Johannes Thumshirn , linux-fsdevel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, drbd-dev@lists.linbit.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Mon 21-09-20 10:07:25, Christoph Hellwig wrote: > aoe forces a larger readahead size, but any reason to do larger I/O > is not limited to readahead. Also set the optimal I/O size, and > remove the local constants in favor of just using SZ_2G. > > Signed-off-by: Christoph Hellwig Looks good. You can add: Reviewed-by: Jan Kara Honza > --- > drivers/block/aoe/aoeblk.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/block/aoe/aoeblk.c b/drivers/block/aoe/aoeblk.c > index 5ca7216e9e01f3..d8cfc233e64b93 100644 > --- a/drivers/block/aoe/aoeblk.c > +++ b/drivers/block/aoe/aoeblk.c > @@ -347,7 +347,6 @@ aoeblk_gdalloc(void *vp) > mempool_t *mp; > struct request_queue *q; > struct blk_mq_tag_set *set; > - enum { KB = 1024, MB = KB * KB, READ_AHEAD = 2 * MB, }; > ulong flags; > int late = 0; > int err; > @@ -407,7 +406,8 @@ aoeblk_gdalloc(void *vp) > WARN_ON(d->gd); > WARN_ON(d->flags & DEVFL_UP); > blk_queue_max_hw_sectors(q, BLK_DEF_MAX_SECTORS); > - q->backing_dev_info->ra_pages = READ_AHEAD / PAGE_SIZE; > + q->backing_dev_info->ra_pages = SZ_2M / PAGE_SIZE; > + blk_queue_io_opt(q, SZ_2M); > d->bufpool = mp; > d->blkq = gd->queue = q; > q->queuedata = d; > -- > 2.28.0 > -- Jan Kara SUSE Labs, CR ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/