From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA582C4346E for ; Tue, 29 Sep 2020 08:33:36 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5869D20759 for ; Tue, 29 Sep 2020 08:33:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="zDCrDKJc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5869D20759 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=SluvyqQ1EjRzQYV/vUv0QQiWunDAU58byFJdJHMmi2g=; b=zDCrDKJc1AeOWZ75uQACBUpQs mpSeWWLv8j8v+U3FsOxh7R5ehf5294vrFR/Os1CKX4Wp+OJxsCrMxShnrNGC8priDAMiWjGPRblvC hBSzuZIEGhzPXkGyen15JcfEYVaWgrhpnOQXfIa8pRyVArqMxTC9a0rKVqYFXt/xWSSbB6rh+WNwQ degnPnFbNUfUthsvkR8BrawUdh7epspGCmoRPuzx2TqrZ4BK0uJs4DSEDHTIRlrTNeRRfEDXJhj6t QVer6NZBcYCc+GMUPtqdIQLrj4Mpnqqu7+viavh4/7O1jc0JwwQBvVUPB7hSjdtdwtEe842ovZuDG gHcRlSdwg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNB3s-0003Cb-P7; Tue, 29 Sep 2020 08:32:36 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNB3p-0003Aw-JW for linux-mtd@lists.infradead.org; Tue, 29 Sep 2020 08:32:34 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kNB3o-0002zp-Kn; Tue, 29 Sep 2020 10:32:32 +0200 Received: from sha by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1kNB3o-0006FY-7q; Tue, 29 Sep 2020 10:32:32 +0200 Date: Tue, 29 Sep 2020 10:32:32 +0200 From: Sascha Hauer To: Richard Weinberger Subject: Re: [PATCH] ubifs: journal: Make sure to not dirty twice for auth nodes Message-ID: <20200929083232.GA11648@pengutronix.de> References: <20200928190612.12074-1-richard@nod.at> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200928190612.12074-1-richard@nod.at> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 10:31:25 up 222 days, 16:01, 152 users, load average: 0.20, 0.16, 0.24 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-mtd@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200929_043233_663552_E420F12D X-CRM114-Status: GOOD ( 12.39 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kristof Havasi , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Mon, Sep 28, 2020 at 09:06:12PM +0200, Richard Weinberger wrote: > When removing the last reference of an inode the size of an auth node > is already part of write_len. So we must not call ubifs_add_auth_dirt(). > Call it only when needed. > > Cc: > Cc: Sascha Hauer > Cc: Kristof Havasi > Fixes: 6a98bc4614de ("ubifs: Add authentication nodes to journal") > Reported-by: Kristof Havasi > Signed-off-by: Richard Weinberger Looked at the code until I understood what the problem is and how it is fixed, so: Reviewed-by: Sascha Hauer Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/