From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: Vignesh Raghavendra <vigneshr@ti.com>,
Tudor Ambarus <Tudor.Ambarus@microchip.com>,
Julien Su <juliensu@mxic.com.tw>,
Richard Weinberger <richard@nod.at>,
ycllin@mxic.com.tw, linux-mtd@lists.infradead.org
Subject: Re: [PATCH 2/5] mtd: spinand: Move ECC related definitions earlier in the driver
Date: Thu, 1 Oct 2020 10:36:24 +0200 [thread overview]
Message-ID: <20201001103624.10672f23@xps13> (raw)
In-Reply-To: <20200930205226.533d4887@windsurf.home>
Hi Thomas,
Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote on Wed, 30 Sep
2020 20:52:26 +0200:
> On Wed, 30 Sep 2020 17:41:06 +0200
> Miquel Raynal <miquel.raynal@bootlin.com> wrote:
>
> > Prepare the creation of a SPI-NAND on-die ECC engine by gathering the
> > ECC-related code earlier enough in the core to avoid the need for
> > forward declarations.
> >
> > The next step is to actually create that engine by implementing the
> > generic ECC interface.
> >
> > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> > ---
> > drivers/mtd/nand/spi/core.c | 106 +++++++++++------------
> > drivers/mtd/nand/spi/on-die-ecc-engine.c | 0
> > 2 files changed, 53 insertions(+), 53 deletions(-)
> > create mode 100644 drivers/mtd/nand/spi/on-die-ecc-engine.c
>
> You're adding an empty on-die-ecc-engine.c file in this commit.
>
> Thomas
Mmmh, this is a left over from a previous implementation, I didn't see
it in the diff, thanks for spotting it!
Cheers,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2020-10-01 8:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 15:41 [PATCH 0/5] Creation of a SPI-NAND ECC engine Miquel Raynal
2020-09-30 15:41 ` [PATCH 1/5] mtd: spinand: Fix typo in comment Miquel Raynal
2020-10-30 17:28 ` Miquel Raynal
2020-09-30 15:41 ` [PATCH 2/5] mtd: spinand: Move ECC related definitions earlier in the driver Miquel Raynal
2020-09-30 18:52 ` Thomas Petazzoni
2020-10-01 8:36 ` Miquel Raynal [this message]
2020-10-30 17:28 ` Miquel Raynal
2020-09-30 15:41 ` [PATCH 3/5] mtd: spinand: Instantiate a SPI-NAND on-die ECC engine Miquel Raynal
2020-10-30 17:28 ` Miquel Raynal
2020-09-30 15:41 ` [PATCH 4/5] mtd: nand: Let on-die ECC engines be retrieved from the NAND core Miquel Raynal
2020-10-30 17:28 ` Miquel Raynal
2020-09-30 15:41 ` [PATCH 5/5] mtd: spinand: Fill a default ECC provider/algorithm Miquel Raynal
2020-10-30 17:28 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201001103624.10672f23@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=Tudor.Ambarus@microchip.com \
--cc=juliensu@mxic.com.tw \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
--cc=thomas.petazzoni@bootlin.com \
--cc=vigneshr@ti.com \
--cc=ycllin@mxic.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).