Linux-mtd Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Manuel Dipolt <mdipolt@robart.cc>
Cc: Roland Ruckerbauer <rruckerbauer@robart.cc>,
	linux-mtd <linux-mtd@lists.infradead.org>,
	maxime <maxime@cerno.tech>,
	bbrezillon@kernel.org
Subject: Re: [PATCH -next] mtd: sunxi-nand: add dma support for allwinner h3
Date: Mon, 5 Oct 2020 14:34:23 +0200	[thread overview]
Message-ID: <20201005143423.5a9dd1ee@xps13> (raw)
In-Reply-To: <1203329103.515411.1601900419875.JavaMail.zimbra@robart.cc>

Hi Manuel,

Manuel Dipolt <mdipolt@robart.cc> wrote on Mon, 5 Oct 2020 14:20:19
+0200 (CEST):

> The Allwinner H3 soc is using different dma mode,
> see old sunxi drivers https://github.com/allwinner-zh/linux-3.4-sunxi/tree/master/modules/nand
> 
> Added support for it and a compatible option sun8i-h3-nand-controller,
> which using sunxi_nfc_h3_caps with a new dma_option field, which is set to 0 for the H3.
> 
> 
> 

There are a few obvious style issues in your patch, can you please run

	$ scripts/checkpatch.pl --strict

and address all the reported errors in a v2?

Thanks!
Miquèl

> Signed-off-by: Manuel Dipolt <manuel.dipolt@robart.cc>

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2020-10-05 12:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-05 12:20 [PATCH -next] mtd: sunxi-nand: add dma support for allwinner h3 Manuel Dipolt
2020-10-05 12:34 ` Miquel Raynal [this message]
2020-10-05 14:56   ` [PATCH v2] mtd: sunxi-nand: add dma support for allwinner h3 - corrected obvious style issues Manuel Dipolt
2020-10-05 13:09 ` [PATCH -next] mtd: sunxi-nand: add dma support for allwinner h3 Boris Brezillon
2020-10-06 17:20   ` [PATCH v3] mtd: sunxi-nand: add dma support for allwinner h3 - review changes Manuel Dipolt
2020-10-07 13:02     ` Boris Brezillon
2020-10-07 14:21       ` Manuel Dipolt
2020-10-08 14:31         ` Fwd: " Manuel Dipolt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201005143423.5a9dd1ee@xps13 \
    --to=miquel.raynal@bootlin.com \
    --cc=bbrezillon@kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=maxime@cerno.tech \
    --cc=mdipolt@robart.cc \
    --cc=rruckerbauer@robart.cc \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox