From: Boris Brezillon <boris.brezillon@collabora.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: richard@nod.at, linux-mtd@lists.infradead.org, vigneshr@ti.com,
Sven Eckelmann <sven@narfation.org>,
rminnich@google.com
Subject: Re: [PATCH] mtd: parser: cmdline: Fix parsing of part-names with colons
Date: Mon, 23 Nov 2020 09:57:20 +0100 [thread overview]
Message-ID: <20201123095720.286cb4ad@collabora.com> (raw)
In-Reply-To: <20201123093814.1c24dd25@xps13>
On Mon, 23 Nov 2020 09:38:14 +0100
Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> Hi Sven,
>
> Sven Eckelmann <sven@narfation.org> wrote on Sun, 22 Nov 2020 01:15:33
> +0100:
>
> > Some devices (especially QCA ones) are already using hardcoded partition
> > names with colons in it. The OpenMesh A62 for example provides following
> > mtd relevant information via cmdline:
> >
> > root=31:11 mtdparts=spi0.0:256k(0:SBL1),128k(0:MIBIB),384k(0:QSEE),64k(0:CDT),64k(0:DDRPARAMS),64k(0:APPSBLENV),512k(0:APPSBL),64k(0:ART),64k(custom),64k(0:KEYS),0x002b0000(kernel),0x00c80000(rootfs),15552k(inactive) rootfsname=rootfs rootwait
> >
> > The change to split only on the last colon between mtd-id and partitions
> > will cause newpart to see following string for the first partition:
> >
> > KEYS),0x002b0000(kernel),0x00c80000(rootfs),15552k(inactive)
> >
> > Such a partition list cannot be parsed and thus the device fails to boot.
> >
> > Avoid this behavior by making sure that the start of the first part-name
> > ("(") will also be the last byte the mtd-id split algorithm is using for
> > its colon search.
Sounds reasonable to me. Note that it works until people start using
parens in their MTD name, so let's hope nobody does that :D. We should
really rework the mtdpart parsing code to make it more robust (do
context based parsing instead of this simple 'strchr()' solution).
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
prev parent reply other threads:[~2020-11-23 8:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-22 0:15 [PATCH] mtd: parser: cmdline: Fix parsing of part-names with colons Sven Eckelmann
2020-11-23 8:38 ` Miquel Raynal
2020-11-23 8:57 ` Boris Brezillon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201123095720.286cb4ad@collabora.com \
--to=boris.brezillon@collabora.com \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=rminnich@google.com \
--cc=sven@narfation.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).