From: Sascha Hauer <s.hauer@pengutronix.de>
To: Han Xu <han.xu@nxp.com>
Cc: linux-mtd@lists.infradead.org, miquel.raynal@bootlin.com
Subject: Re: [PATCH v2 1/2] mtd: rawnand: gpmi: Fix the driver only sense CS0 R/B issue
Date: Thu, 10 Dec 2020 10:45:57 +0100 [thread overview]
Message-ID: <20201210094557.GT3977@pengutronix.de> (raw)
In-Reply-To: <20201209035104.22679-2-han.xu@nxp.com>
On Tue, Dec 08, 2020 at 09:51:03PM -0600, Han Xu wrote:
> set the GPMI CTRL1 GANGED_RDYBUSY bit so dirver can sense the R/B signal
> from all CS.
>
> For the NAND chip MT29F64G08AFAAAWP, only the first chip detected
> without the patch.
>
> [ 3.764118] nand: device found, Manufacturer ID: 0x2c, Chip ID: 0x68
> [ 3.770613] nand: Micron MT29F64G08AFAAAWP
> [ 3.774752] nand: 4096 MiB, SLC, erase size: 1024 KiB, page size: 8192, OOB size: 448
> [ 3.786421] Bad block table found at page 524160, version 0x01
> [ 3.792730] Bad block table found at page 524032, version 0x01
>
> After applying the patch
>
> [ 3.764445] nand: device found, Manufacturer ID: 0x2c, Chip ID: 0x68
> [ 3.770941] nand: Micron MT29F64G08AFAAAWP
> [ 3.775080] nand: 4096 MiB, SLC, erase size: 1024 KiB, page size: 8192, OOB size: 448
> [ 3.784390] nand: 2 chips detected
> [ 3.790900] Bad block table found at page 524160, version 0x01
> [ 3.796776] Bad block table found at page 1048448, version 0x01
>
> Signed-off-by: Han Xu <han.xu@nxp.com>
Acked-by: Sascha Hauer <s.hauer@pengutronix.de>
Sascha
> ---
> drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c | 6 ++++--
> drivers/mtd/nand/raw/gpmi-nand/gpmi-regs.h | 1 +
> 2 files changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c
> index 0d30f3fbb045..b06e202cdd0d 100644
> --- a/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c
> +++ b/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c
> @@ -181,9 +181,11 @@ static int gpmi_init(struct gpmi_nand_data *this)
>
> /*
> * Decouple the chip select from dma channel. We use dma0 for all
> - * the chips.
> + * the chips, force all NAND RDY_BUSY inputs to be sourced from
> + * RDY_BUSY0.
> */
> - writel(BM_GPMI_CTRL1_DECOUPLE_CS, r->gpmi_regs + HW_GPMI_CTRL1_SET);
> + writel(BM_GPMI_CTRL1_DECOUPLE_CS | BM_GPMI_CTRL1_GANGED_RDYBUSY,
> + r->gpmi_regs + HW_GPMI_CTRL1_SET);
>
> err_out:
> pm_runtime_mark_last_busy(this->dev);
> diff --git a/drivers/mtd/nand/raw/gpmi-nand/gpmi-regs.h b/drivers/mtd/nand/raw/gpmi-nand/gpmi-regs.h
> index f5e4f26c34da..fc31fd084dcf 100644
> --- a/drivers/mtd/nand/raw/gpmi-nand/gpmi-regs.h
> +++ b/drivers/mtd/nand/raw/gpmi-nand/gpmi-regs.h
> @@ -107,6 +107,7 @@
> #define BV_GPMI_CTRL1_WRN_DLY_SEL_7_TO_12NS 0x2
> #define BV_GPMI_CTRL1_WRN_DLY_SEL_NO_DELAY 0x3
>
> +#define BM_GPMI_CTRL1_GANGED_RDYBUSY (1 << 19)
> #define BM_GPMI_CTRL1_BCH_MODE (1 << 18)
>
> #define BP_GPMI_CTRL1_DLL_ENABLE 17
> --
> 2.17.1
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2020-12-10 9:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-09 3:51 [PATCH v2 0/2] fix some gpmi nand driver bugs Han Xu
2020-12-09 3:51 ` [PATCH v2 1/2] mtd: rawnand: gpmi: Fix the driver only sense CS0 R/B issue Han Xu
2020-12-10 9:45 ` Sascha Hauer [this message]
2020-12-10 9:54 ` Fabio Estevam
2020-12-10 21:39 ` Miquel Raynal
2020-12-09 3:51 ` [PATCH v2 2/2] mtd: rawnand: gpmi: Fix the random DMA timeout issue Han Xu
2020-12-10 21:39 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201210094557.GT3977@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=han.xu@nxp.com \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).