Re: [PATCH] mtd: phram: use div_u64_rem to stop overwrite len in phram_setup

yangerkun
2021-01-25T05:50:38Z

Hi,

Recheck the patch, and it seems we need check erasesize to prevent DIV/0...

Sorry for the mistake. Can you add a fix patch for this?

Thanks,
Kun.

在 2021/1/4 18:18, Miquel Raynal 写道:
> On Wed, 2020-12-30 at 02:17:18 UTC, yangerkun wrote:
>> We now support user to set erase page size, and use do_div between len
>> and erase size to determine the reasonableness for the erase size.
>> However, do_div is a macro and will overwrite the value of len. Which
>> results a mtd device with unexcepted size. Fix it by use div_u64_rem.
>>
>> Fixes: ffad560394de ("mtd: phram: Allow the user to set the erase page size.")
>> Signed-off-by: yangerkun <yangerkun@huawei.com>
>
> Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks.
>
> Miquel
> .