From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Zheng Yongjun <zhengyongjun3@huawei.com>
Cc: richard@nod.at, linux-mtd@lists.infradead.org, vigneshr@ti.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] mtd: use resource_size
Date: Wed, 6 Jan 2021 15:49:54 +0100 [thread overview]
Message-ID: <20210106154954.4f85ed76@xps13> (raw)
In-Reply-To: <20210106131831.301-1-zhengyongjun3@huawei.com>
Hello,
Zheng Yongjun <zhengyongjun3@huawei.com> wrote on Wed, 6 Jan 2021
21:18:31 +0800:
> Use resource_size rather than a verbose computation on
> the end and start fields.
The commit message and the patch content do not match.
>
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
> ---
> drivers/mtd/maps/pci.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mtd/maps/pci.c b/drivers/mtd/maps/pci.c
> index 377ef0fc4e3e..ca00d211e73e 100644
> --- a/drivers/mtd/maps/pci.c
> +++ b/drivers/mtd/maps/pci.c
> @@ -90,8 +90,8 @@ intel_iq80310_init(struct pci_dev *dev, struct map_pci_info *map)
> u32 win_base;
>
> map->map.bankwidth = 1;
> - map->map.read = mtd_pci_read8,
> - map->map.write = mtd_pci_write8,
> + map->map.read = mtd_pci_read8;
> + map->map.write = mtd_pci_write8;
>
> map->map.size = 0x00800000;
> map->base = ioremap(pci_resource_start(dev, 0),
> @@ -185,8 +185,8 @@ intel_dc21285_init(struct pci_dev *dev, struct map_pci_info *map)
> return -ENXIO;
>
> map->map.bankwidth = 4;
> - map->map.read = mtd_pci_read32,
> - map->map.write = mtd_pci_write32,
> + map->map.read = mtd_pci_read32;
> + map->map.write = mtd_pci_write32;
> map->map.size = len;
> map->base = ioremap(base, len);
>
Thanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
prev parent reply other threads:[~2021-01-06 14:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-06 13:18 [PATCH -next] mtd: use resource_size Zheng Yongjun
2021-01-06 14:49 ` Miquel Raynal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210106154954.4f85ed76@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
--cc=zhengyongjun3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox