From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Baruch Siach <baruch@tkos.co.il>
Cc: Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
linux-mtd@lists.infradead.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH] mtd: parsers: qcom: incompatible with spi-nor 4k sectors
Date: Wed, 3 Mar 2021 21:54:52 +0530 [thread overview]
Message-ID: <20210303162452.GA4319@thinkpad> (raw)
In-Reply-To: <71e3fe832d35bd34a7da87146ba7d52f89278665.1614780732.git.baruch@tkos.co.il>
On Wed, Mar 03, 2021 at 04:12:12PM +0200, Baruch Siach wrote:
> Partition size and offset value are in block size units, which is the
> same as 'erasesize'. But when 4K sectors are enabled erasesize is set to
> 4K. Bail out in that case.
>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
> drivers/mtd/parsers/qcomsmempart.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/mtd/parsers/qcomsmempart.c b/drivers/mtd/parsers/qcomsmempart.c
> index 808cb33d71f8..f851574e1b52 100644
> --- a/drivers/mtd/parsers/qcomsmempart.c
> +++ b/drivers/mtd/parsers/qcomsmempart.c
> @@ -65,6 +65,13 @@ static int parse_qcomsmem_part(struct mtd_info *mtd,
> int ret, i, numparts;
> char *name, *c;
>
> + if (IS_ENABLED(CONFIG_MTD_SPI_NOR_USE_4K_SECTORS)
> + && mtd->type == MTD_NORFLASH) {
> + pr_err("%s: SMEM partition parse is incompatible with 4K sectors\n",
s/parse/parser
With that and the fixes tag,
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Thanks,
Mani
> + mtd->name);
> + return -EINVAL;
> + }
> +
> pr_debug("Parsing partition table info from SMEM\n");
> ptable = qcom_smem_get(SMEM_APPS, SMEM_AARM_PARTITION_TABLE, &len);
> if (IS_ERR(ptable)) {
> --
> 2.30.1
>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
prev parent reply other threads:[~2021-03-03 23:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-03 14:12 [PATCH] mtd: parsers: qcom: incompatible with spi-nor 4k sectors Baruch Siach
2021-03-03 14:19 ` Miquel Raynal
2021-03-03 16:24 ` Manivannan Sadhasivam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210303162452.GA4319@thinkpad \
--to=manivannan.sadhasivam@linaro.org \
--cc=baruch@tkos.co.il \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).