From: Pratyush Yadav <p.yadav@ti.com>
To: Michael Walle <michael@walle.cc>
Cc: Kuldeep Singh <kuldeep.singh@nxp.com>,
<linux-spi@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, Mark Brown <broonie@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Vladimir Oltean <olteanv@gmail.com>,
<linux-mtd@lists.infradead.org>
Subject: Re: [PATCH] dt-bindings: spi: Convert Freescale DSPI to json schema
Date: Tue, 16 Mar 2021 23:36:58 +0530 [thread overview]
Message-ID: <20210316180655.6oidvffum7yuwknr@ti.com> (raw)
In-Reply-To: <067c42f3726578ebe60d201a141dfdb6@walle.cc>
On 16/03/21 06:45PM, Michael Walle wrote:
> Am 2021-03-15 19:30, schrieb Pratyush Yadav:
>
> ..
> > > +patternProperties:
> > > + "@[0-9a-f]+":
>
> Shouldn't this be "^.*@[0-9a-f]+$"?
The pattern has to match _anywhere_ in the string so both should match
the flash node. Your pattern is more "strict" or "precise". See the note
at [0].
[0] https://json-schema.org/understanding-json-schema/reference/string.html#regular-expressions
>
> > > + type: object
> > > +
> > > + properties:
> > > + fsl,spi-cs-sck-delay:
> > > + description:
> > > + Delay in nanoseconds between activating chip select and
> > > the start of
> > > + clock signal, at the start of a transfer.
> > > + $ref: /schemas/types.yaml#/definitions/uint32
> > > +
> > > + fsl,spi-sck-cs-delay:
> > > + description:
> > > + Delay in nanoseconds between stopping the clock signal and
> > > + deactivating chip select, at the end of a transfer.
> > > + $ref: /schemas/types.yaml#/definitions/uint32
> > > +
> ..
>
> -michael
--
Regards,
Pratyush Yadav
Texas Instruments Inc.
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2021-03-16 18:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210315121518.3710171-1-kuldeep.singh@nxp.com>
2021-03-15 18:30 ` [PATCH] dt-bindings: spi: Convert Freescale DSPI to json schema Pratyush Yadav
2021-03-16 5:56 ` [EXT] " Kuldeep Singh
2021-03-16 17:45 ` Michael Walle
2021-03-16 18:06 ` Pratyush Yadav [this message]
2021-03-16 18:22 ` Michael Walle
2021-03-24 17:51 ` Rob Herring
2021-03-22 13:20 ` Pratyush Yadav
2021-03-24 18:10 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210316180655.6oidvffum7yuwknr@ti.com \
--to=p.yadav@ti.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kuldeep.singh@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=michael@walle.cc \
--cc=olteanv@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox