From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A191C433ED for ; Fri, 2 Apr 2021 08:54:19 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A5E6D61104 for ; Fri, 2 Apr 2021 08:54:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A5E6D61104 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Xi3t3rxHNI4XbXYvGzRWp/gADjF2mda5wGeIXN5HW2k=; b=nxshwdeCRV7vCfTlR/jBMcgYM RcHMp+1c00kjphFRJP2Q5OPEdWatu6s1BWP7BeCYyVrfe5RNAmmzS5hi+bp2imwqQkZOsbVL+me5o muLAjuw357rwM2odSeSOQGb7khxPCfvvQZiGuJ5KFekzFGJpzUrdd3hfziNItfVydpisk8Fz0XDJS KWQIEXpHbY2DkCh4SbnoVTMiS+zT5CFHRaB3qojz4QyfuXTV0wBBPMrdVyTIBMs2KExD+mxDZPeXh FJXdWjuBPwMnUZOD1tjFECje9ItAaYultepVA+cN+LY4IKlimcR0FB4E4h2vBXgjdpA0phgt4brkE V+AewOt0g==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lSFY5-00COND-F4; Fri, 02 Apr 2021 08:53:01 +0000 Received: from bhuna.collabora.co.uk ([46.235.227.227]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lSFX5-00CNp9-Bb for linux-mtd@lists.infradead.org; Fri, 02 Apr 2021 08:52:03 +0000 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 42FC31F4671A; Fri, 2 Apr 2021 09:51:58 +0100 (BST) Date: Fri, 2 Apr 2021 10:51:54 +0200 From: Boris Brezillon To: Manivannan Sadhasivam Cc: miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, robh+dt@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Daniele.Palmas@telit.com, bjorn.andersson@linaro.org Subject: Re: [PATCH v10 3/4] mtd: rawnand: Add support for secure regions in NAND memory Message-ID: <20210402105154.0a2a3af5@collabora.com> In-Reply-To: <20210401161622.GH14052@work> References: <20210401151955.143817-1-manivannan.sadhasivam@linaro.org> <20210401151955.143817-4-manivannan.sadhasivam@linaro.org> <20210401175421.65db63bf@collabora.com> <20210401161622.GH14052@work> Organization: Collabora X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210402_095200_003503_B5A5E61E X-CRM114-Status: GOOD ( 16.47 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Thu, 1 Apr 2021 21:46:22 +0530 Manivannan Sadhasivam wrote: > On Thu, Apr 01, 2021 at 05:54:21PM +0200, Boris Brezillon wrote: > > On Thu, 1 Apr 2021 20:49:54 +0530 > > Manivannan Sadhasivam wrote: > > > > > @@ -565,6 +608,11 @@ static int nand_block_isreserved(struct mtd_info *mtd, loff_t ofs) > > > > > > if (!chip->bbt) > > > return 0; > > > + > > > + /* Check if the region is secured */ > > > + if (nand_region_is_secured(chip, ofs, 0)) > > > + return -EIO; > > > > That would is still wrong, you should never pass a 0 size to > > nand_region_is_secured(). > > > > Size doesn't matter here, that's why I passed 0. Maybe 1 would be > appropriate? You're checking if a block is reserved, so I think passing the eraseblock size would make more sense, but I actually don't understand why you need to check if the region is secure here (looks like nand_block_isreserved() does not access the flash). ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/