From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F26DBC2B9F7 for ; Wed, 26 May 2021 11:07:05 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B196B6108E for ; Wed, 26 May 2021 11:07:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B196B6108E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Nsj+IUV3JfZAI1jYyWIGILlUygO5QeI5PIQWNdnKg+o=; b=SwHmQhlaJUwlVQ Pt+0EUbOcSq83Vhx+wIBKeRvI4aFGGMFUYMp+YFSts8rrTHYH6yGCM2bQwU9yeeuOoR0pDPGVEgvT +esXdLBN0FxjFM5YDbq6Y+ZbqiDLsANBTMAh0HYts5jjaXVdCNjwT0MhAwhh77h6WAM7e2TOm1gJn lx88shA8W8MNrYzXUFGDrh1kK1+hniPJXYwBJ0r0c14r+HNlGJLRLFoMGEJlvXsQVPt9TrSLwa+oF 8iyOwaue+OMAujP6L1WBP8GsPqcOWKFCFhVrZnggR0+w+jkbs1xs59KRz1S/5xewqEAG11voNlwTQ zdK9biPcbAu7CcR+3FVQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1llrMm-00DPnu-Hs; Wed, 26 May 2021 11:06:25 +0000 Received: from mga02.intel.com ([134.134.136.20]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1llpaz-00ClzI-BU for linux-mtd@lists.infradead.org; Wed, 26 May 2021 09:12:58 +0000 IronPort-SDR: 4zkqxMzoR8I2qFC5p7Kuo/WlMpb13r9a/kCMvVkM00h0W1RWLdxMWSE0WuogAM2Ehqqc1vjBZh EW82Rr4VkctQ== X-IronPort-AV: E=McAfee;i="6200,9189,9995"; a="189540523" X-IronPort-AV: E=Sophos;i="5.82,331,1613462400"; d="scan'208";a="189540523" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 May 2021 02:12:56 -0700 IronPort-SDR: pZ0TrN95m2JKlKjNPf79VtDRkX360g8vX/iItzgmbuwFaODxmgF6Y/7cJ2OmBcDhnkbb51HgmX H3OzaDX7FgOQ== X-IronPort-AV: E=Sophos;i="5.82,331,1613462400"; d="scan'208";a="443930827" Received: from lahna.fi.intel.com (HELO lahna) ([10.237.72.163]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 May 2021 02:12:53 -0700 Received: by lahna (sSMTP sendmail emulation); Wed, 26 May 2021 12:12:50 +0300 Date: Wed, 26 May 2021 12:12:50 +0300 From: Mika Westerberg To: Pratyush Yadav Cc: Tudor Ambarus , Michael Walle , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , linux-mtd@lists.infradead.org Subject: Re: [PATCH] mtd: spi-nor: intel-spi: Add support for second flash chip Message-ID: <20210526091250.GY291593@lahna.fi.intel.com> References: <20210525160318.35802-1-mika.westerberg@linux.intel.com> <20210525191414.dc45h27rzqen4dce@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210525191414.dc45h27rzqen4dce@ti.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210526_021257_481824_825195AB X-CRM114-Status: GOOD ( 27.23 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org Hi, On Wed, May 26, 2021 at 12:44:16AM +0530, Pratyush Yadav wrote: > Hi, > > On 25/05/21 07:03PM, Mika Westerberg wrote: > > Intel SPI flash controller has been supporting two chip selects long > > time already even if the most common configuration is to have single > > flash chip for the BIOS and related data. This adds support for the > > second chip select if we find out that there are two flash components > > (this information is available in the mandatory flash descriptor on the > > first chip). The second chip is exposed as is without any partition > > information with name "chip1". The first chip continues work as is. > > > > Signed-off-by: Mika Westerberg > > --- > > drivers/mtd/spi-nor/controllers/intel-spi.c | 208 ++++++++++++++------ > > Aren't the drivers in controllers/ supposed to move to use SPI MEM? I > don't know if this has been discussed before, but I would like all > drivers in controllers/ to move to SPI MEM API at some point in the > future. This would let us drop support for this "legacy" controller API > from SPI NOR, cleaning up the core quite a bit. No more if (nor->spimem) > needed anywhere. What is SPI MEM? :) Looking at the mainline v5.13-rc3 controllers/ there is no single driver "converted" to SPI MEM, at least from a quick clance. > I wonder what other folks think about this. I vote for freezing all new > features in controllers/. If you want something new, move to SPI MEM. I think at this point it is not reasonable to expect that all controller drivers move to your new framework that has not even landed the mainline ;-) Or did I miss something? ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/