From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAC54C2B9F4 for ; Thu, 17 Jun 2021 07:58:31 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BAC9F6101A for ; Thu, 17 Jun 2021 07:58:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BAC9F6101A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=U70HL/wAPZ1jji9BVnDxHyoxUOI66W9DdRAF5jrgZGA=; b=2auNrDo7nxW4m/ ISeKcoXEPpAS0wKw3NH3f0vE/RYS1pO2LjhNCMbQAn4mZBwLQdBU7kF1sGik1uIbKwiiL6Ps/Je1h D5m/ENbkegKSHUOtkGWEnJWym2KIIUp7zV+mYRGRt7vKlHeQY1zxDGTtoHhXjyVECNcLOWBCIkY/C d9xfvTj7vzgwdYXWHoSwn5lkahCqi1KA9bvvn7QDzRpdgpCk5+7573YhqTocvMEjyUT2zOFuIgxcu WOZ1migWl3VGDsoiyToEEiol/w2ecq5shjaXmDkVUU9k50pwxmj62OAr0iKw4QtNzmKGR1Dqku5G0 C0uLuf8L4i/oBPh8eKZw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltmuM-009OIu-NC; Thu, 17 Jun 2021 07:57:50 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltmuJ-009OHe-Nv for linux-mtd@lists.infradead.org; Thu, 17 Jun 2021 07:57:49 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id BB49668C4E; Thu, 17 Jun 2021 09:57:45 +0200 (CEST) Date: Thu, 17 Jun 2021 09:57:45 +0200 From: Christoph Hellwig To: Kees Cook Cc: linux-kernel@vger.kernel.org, Christoph Hellwig , Al Viro , gmpy.liaowx@gmail.com, Anton Vorontsov , Colin Cross , Tony Luck , Jonathan Corbet , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , linux-doc@vger.kernel.org, linux-mtd@lists.infradead.org, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v3 5/5] pstore/blk: Include zone in pstore_device_info Message-ID: <20210617075745.GC899@lst.de> References: <20210616164043.1221861-1-keescook@chromium.org> <20210616164043.1221861-6-keescook@chromium.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210616164043.1221861-6-keescook@chromium.org> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210617_005747_965213_9904C057 X-CRM114-Status: GOOD ( 11.32 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Wed, Jun 16, 2021 at 09:40:43AM -0700, Kees Cook wrote: > Information was redundant between struct pstore_zone_info and struct > pstore_device_info. Use struct pstore_zone_info, with member name "zone". > > Additionally untangle the logic for the "best effort" block device > instance. I'd still prefer to kill off struct pstore_device_info, but this is already a huge improvement: Reviewed-by: Christoph Hellwig ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/