From: Rasmus Villemoes <linux@rasmusvillemoes.dk>
To: linux-mtd@lists.infradead.org
Cc: Frieder Schrempf <frieder.schrempf@kontron.de>,
Boris Brezillon <bbrezillon@kernel.org>,
Tudor Ambarus <tudor.ambarus@microchip.com>,
Michael Walle <michael@walle.cc>, Pratyush Yadav <p.yadav@ti.com>,
linux-kernel@vger.kernel.org, Esben Haabendal <esben@geanix.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>
Subject: [RFC 1/3] mtd: spi-nor: core: create helper to compare JEDEC id to struct flash_info
Date: Mon, 21 Jun 2021 17:23:18 +0200 [thread overview]
Message-ID: <20210621152320.3811194-2-linux@rasmusvillemoes.dk> (raw)
In-Reply-To: <20210621152320.3811194-1-linux@rasmusvillemoes.dk>
This check will be used elsewhere in a later patch, so factor out the
logic to a helper function.
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
---
drivers/mtd/spi-nor/core.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c
index bd2c7717eb10..6a1adef0fe9f 100644
--- a/drivers/mtd/spi-nor/core.c
+++ b/drivers/mtd/spi-nor/core.c
@@ -1850,6 +1850,11 @@ static const struct spi_nor_manufacturer *manufacturers[] = {
&spi_nor_xmc,
};
+static bool spi_nor_match_part(const struct flash_info *part, const u8 *id)
+{
+ return part->id_len && !memcmp(part->id, id, part->id_len);
+}
+
static const struct flash_info *
spi_nor_search_part_by_id(const struct flash_info *parts, unsigned int nparts,
const u8 *id)
@@ -1857,8 +1862,7 @@ spi_nor_search_part_by_id(const struct flash_info *parts, unsigned int nparts,
unsigned int i;
for (i = 0; i < nparts; i++) {
- if (parts[i].id_len &&
- !memcmp(parts[i].id, id, parts[i].id_len))
+ if (spi_nor_match_part(&parts[i], id))
return &parts[i];
}
--
2.31.1
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2021-06-21 15:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-21 15:23 [RFC 0/3] mtd: spi-nor: dealing with reused JEDEC id c22016 Rasmus Villemoes
2021-06-21 15:23 ` Rasmus Villemoes [this message]
2021-06-21 15:23 ` [RFC 2/3] mtd: spi-nor: core: compare JEDEC bytes to already found flash_info Rasmus Villemoes
2021-06-22 11:57 ` Michael Walle
2021-06-22 20:58 ` Rasmus Villemoes
2021-06-23 6:46 ` Tudor.Ambarus
2021-07-02 13:17 ` Rasmus Villemoes
2021-07-02 13:34 ` Tudor.Ambarus
[not found] ` <OF7CD5328D.D33B2BE2-ON482586FD.0027BCF2-482586FD.00280249@mxic.com.tw>
2021-06-23 8:33 ` 回信: " Tudor.Ambarus
2021-06-29 7:42 ` Rasmus Villemoes
2021-06-21 15:23 ` [RFC 3/3] mtd: spi-nor: macronix: add entry for mx25l3233f Rasmus Villemoes
2021-06-22 8:55 ` [RFC 0/3] mtd: spi-nor: dealing with reused JEDEC id c22016 Rasmus Villemoes
2021-06-22 9:26 ` Esben Haabendal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210621152320.3811194-2-linux@rasmusvillemoes.dk \
--to=linux@rasmusvillemoes.dk \
--cc=bbrezillon@kernel.org \
--cc=esben@geanix.com \
--cc=frieder.schrempf@kontron.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=michael@walle.cc \
--cc=p.yadav@ti.com \
--cc=tudor.ambarus@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox