Re: [PATCH] dt-bindings: mtd: spi-nand: Convert to DT schema format

Nandan, Apurva
2021-07-20T14:16:47Z

On 19-Jul-21 8:54 PM, Rob Herring wrote:
> On Sun, Jul 18, 2021 at 12:41:25AM +0000, Apurva Nandan wrote:
>> Convert spi-nand.txt binding to YAML format with an added example.
>>
>> Signed-off-by: Apurva Nandan <a-nandan@ti.com>
>> ---
>> .../devicetree/bindings/mtd/spi-nand.txt | 5 --
>> .../devicetree/bindings/mtd/spi-nand.yaml | 74 +++++++++++++++++++
>> 2 files changed, 74 insertions(+), 5 deletions(-)
>> delete mode 100644 Documentation/devicetree/bindings/mtd/spi-nand.txt
>> create mode 100644 Documentation/devicetree/bindings/mtd/spi-nand.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/mtd/spi-nand.txt b/Documentation/devicetree/bindings/mtd/spi-nand.txt
>> deleted file mode 100644
>> index 8b51f3b6d55c..000000000000
>> --- a/Documentation/devicetree/bindings/mtd/spi-nand.txt
>> +++ /dev/null
>> @@ -1,5 +0,0 @@
>> -SPI NAND flash
>> -
>> -Required properties:
>> -- compatible: should be "spi-nand"
>> -- reg: should encode the chip-select line used to access the NAND chip
>> diff --git a/Documentation/devicetree/bindings/mtd/spi-nand.yaml b/Documentation/devicetree/bindings/mtd/spi-nand.yaml
>> new file mode 100644
>> index 000000000000..366b86e1b19c
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/mtd/spi-nand.yaml
>> @@ -0,0 +1,74 @@
>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/mtd/spi-nand.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: SPI NAND flash
>> +
>> +maintainers:
>> + - Apurva Nandan <a-nandan@ti.com>
>> +
>> +allOf:
>> + - $ref: "mtd.yaml#"
>> +
>> +properties:
>> + compatible:
>> + oneOf:
>> + - const: spi-nand
>
> Drop 'oneOf' as there is only one.
>
>> +
>> + reg:
>> + items:
>> + description:
>> + should encode the chip-select line used to access the NAND chip
>
> Just:
>
> reg:
> maxItems: 1
>
>> +
>> + spi-max-frequency: true
>> + spi-rx-bus-width: true
>> + spi-tx-bus-width: true
>> +
>> + partitions:
>> + type: object
>> +
>> + '#address-cells': true
>> + '#size-cells': true
>> +
>> +patternProperties:
>> + # Note: use 'partitions' node for new users
>> + '^partition@':
>> + type: object
>> +
>> + "^otp(-[0-9]+)?$":
>> + type: object
>> +
>> +additionalProperties: false
>
> Just do:
>
> additionalProperties:
> type: object
>
> and then drop partitions, partition@, and ^otp(-[0-9]+)?$.
>
>> +
>> +examples:
>> + - |
>> + spi {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + flash@6 {
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + compatible = "spi-nand";
>> + reg = <0x6>;
>> + spi-max-frequency = <42000000>;
>> +
>> + partitions {
>> + compatible = "fixed-partitions";
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> +
>> + partition@0 {
>> + label = "boot";
>> + reg = <0 0x200000>;
>> + };
>> +
>> + partition@200000 {
>> + label = "rootfs";
>> + reg = <0x200000 0xce0000>;
>> + };
>> + };
>> + };
>> + };
>> --
>> 2.17.1
>>
>>

Agree with all the suggestions made, will correct and send v2.

Thanks,
Apurva Nandan