From: Sean Young <sean@mess.org>
To: Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
linux-mtd@lists.infradead.org
Subject: [PATCH v2 4/5] mtd: rfd_ftl: fix use-after-free
Date: Sat, 7 Aug 2021 22:45:37 +0100 [thread overview]
Message-ID: <20210807214538.14484-5-sean@mess.org> (raw)
In-Reply-To: <20210807214538.14484-1-sean@mess.org>
del_mtd_blktrans_dev() will kfree part, so after this call both part and
dev point to freed memory. Move the call to avoid use-after-free.
Signed-off-by: Sean Young <sean@mess.org>
---
drivers/mtd/rfd_ftl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/rfd_ftl.c b/drivers/mtd/rfd_ftl.c
index 7f5f6d247cae..52be9f1fa9a2 100644
--- a/drivers/mtd/rfd_ftl.c
+++ b/drivers/mtd/rfd_ftl.c
@@ -800,10 +800,10 @@ static void rfd_ftl_remove_dev(struct mtd_blktrans_dev *dev)
part->mbd.mtd->name, i, part->blocks[i].erases);
}
- del_mtd_blktrans_dev(dev);
vfree(part->sector_map);
kfree(part->header_cache);
kfree(part->blocks);
+ del_mtd_blktrans_dev(dev);
}
static struct mtd_blktrans_ops rfd_ftl_tr = {
--
2.31.1
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2021-08-07 21:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-07 21:45 [PATCH v2 0/5] Fix various issues with RFD and FTLs Sean Young
2021-08-07 21:45 ` [PATCH v2 1/5] mtd: rfd_ftl: allow use of MTD_RAM for testing purposes Sean Young
2021-08-16 14:27 ` Miquel Raynal
2021-08-07 21:45 ` [PATCH v2 2/5] mtd: rfd_ftl: add discard support Sean Young
2021-08-16 14:27 ` Miquel Raynal
2021-08-07 21:45 ` [PATCH v2 3/5] mtd: blk_devs: make discard work on FTLs Sean Young
2021-08-16 14:26 ` Miquel Raynal
2021-08-07 21:45 ` Sean Young [this message]
2021-08-16 14:26 ` [PATCH v2 4/5] mtd: rfd_ftl: fix use-after-free Miquel Raynal
2021-08-07 21:45 ` [PATCH v2 5/5] mtd: rfd_ftl: use container_of() rather than cast Sean Young
2021-08-16 14:26 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210807214538.14484-5-sean@mess.org \
--to=sean@mess.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox