From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Guenter Roeck <linux@roeck-us.net>,
linux-mtd@lists.infradead.org
Subject: Re: mtd locking fix and cleanups
Date: Mon, 23 Aug 2021 10:30:26 +0200 [thread overview]
Message-ID: <20210823103026.0ec7dbb1@xps13> (raw)
In-Reply-To: <20210823073359.705281-1-hch@lst.de>
Hi Christoph,
Christoph Hellwig <hch@lst.de> wrote on Mon, 23 Aug 2021 09:33:51 +0200:
> Hi mtd maintainers,
>
> the first series in this patch fixes a lock order reversal reported by
> Guenter based on a recent commit, although from code inspection it should
> have been around for much longer.
>
> The rest is drive-by cleanups in the area that I noticed while trying to
> understand the locking changes. These are untested and need to be handled
> with care!
Thanks for the fix and the various cleanups, they look good to me. I
don't know how important these drivers are nor if they are still
actually used, it would be good to have some feedback from people still
following. In the mean time I'll apply the series right away, I don't
want to wait an additional month or so because of the merge window.
Thanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
prev parent reply other threads:[~2021-08-23 8:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-23 7:33 mtd locking fix and cleanups Christoph Hellwig
2021-08-23 7:33 ` [PATCH 1/8] mtd_blkdevs: don't hold del_mtd_blktrans_dev in blktrans_{open, release} Christoph Hellwig
2021-08-23 8:33 ` Miquel Raynal
2021-08-23 7:33 ` [PATCH 2/8] mtd_blkdevs: use lockdep_assert_held Christoph Hellwig
2021-08-23 8:33 ` Miquel Raynal
2021-08-23 7:33 ` [PATCH 3/8] mtd/ftl: don't cast away the type when calling add_mtd_blktrans_dev Christoph Hellwig
2021-08-23 8:33 ` Miquel Raynal
2021-08-23 7:33 ` [PATCH 4/8] mtd/rfd_ftl: " Christoph Hellwig
2021-08-23 8:33 ` Miquel Raynal
2021-08-23 7:33 ` [PATCH 5/8] mtd_blkdevs: simplify blktrans_dev_get Christoph Hellwig
2021-08-23 8:33 ` Miquel Raynal
2021-08-23 7:33 ` [PATCH 6/8] mtd_blkdevs: remove blktrans_ref_mutex Christoph Hellwig
2021-08-23 8:33 ` Miquel Raynal
2021-08-23 7:33 ` [PATCH 7/8] mtd_blkdevs: simplify blktrans_getgeo Christoph Hellwig
2021-08-23 8:33 ` Miquel Raynal
2021-08-23 7:33 ` [PATCH 8/8] mtd_blkdevs: simplify the refcounting in blktrans_{open, release} Christoph Hellwig
2021-08-23 8:33 ` Miquel Raynal
2021-08-23 8:30 ` Miquel Raynal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210823103026.0ec7dbb1@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=hch@lst.de \
--cc=linux-mtd@lists.infradead.org \
--cc=linux@roeck-us.net \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox