From: Manivannan Sadhasivam <mani@kernel.org>
To: Md Sadre Alam <mdalam@codeaurora.org>
Cc: miquel.raynal@bootlin.com, linux-mtd@lists.infradead.org,
linux-kernel@vger.kernel.org, sricharan@codeaurora.org
Subject: Re: [PATCH 0/3] Add support for page scope read
Date: Tue, 28 Sep 2021 20:47:37 +0530 [thread overview]
Message-ID: <20210928151737.GA12183@thinkpad> (raw)
In-Reply-To: <1631699851-12172-1-git-send-email-mdalam@codeaurora.org>
Hi,
On Wed, Sep 15, 2021 at 03:27:28PM +0530, Md Sadre Alam wrote:
> These series of patches to support page scope read.
>
> In QPIC v1, SW is needed to write EXEC_CMD register
> for each Code word and collect any Status related to
> that CW before issueing EXEC_CMD for next CW.
>
> Page scope command, currently supported only for read
> commands in bam mode, is truly a page mode command where
> SW is required to issue EXEC_CMD only once for a page.
> Controller HW takes care of Codeword specific details
> and automatically returns status associated with each
> CW to BAM pipe, dedicated for status deposition.
>
This description doesn't clearly convey the intention of the patches. Please
take time to write the cover letter describing what the patches do and how
they solve a problem.
If possible, do mention the platform on which the patches were tested.
And please avoid using Qualcomm specific acronymns such as CW as it only makes
sense to limited amount of people who has access to technical documents.
Thanks,
Mani
> Md Sadre Alam (3):
> mtd: rawnand: qcom: Add support for status pipe
> mtd: rawnand: qcom: Add sg list to handle status pipe request
> mtd: rawnand: qcom: Add support for page scope read
>
> drivers/mtd/nand/raw/qcom_nandc.c | 125 ++++++++++++++++++++++++++++++++++++--
> 1 file changed, 119 insertions(+), 6 deletions(-)
>
> --
> 2.7.4
>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
prev parent reply other threads:[~2021-09-28 15:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-15 9:57 [PATCH 0/3] Add support for page scope read Md Sadre Alam
2021-09-15 9:57 ` [PATCH 1/3] mtd: rawnand: qcom: Add support for status pipe Md Sadre Alam
2021-09-28 12:17 ` mdalam
2021-09-28 12:46 ` Miquel Raynal
2021-09-28 15:52 ` Manivannan Sadhasivam
2021-09-15 9:57 ` [PATCH 2/3] mtd: rawnand: qcom: Add sg list to handle status pipe request Md Sadre Alam
2021-09-28 12:20 ` mdalam
2021-09-28 12:48 ` Miquel Raynal
2021-09-28 16:03 ` Manivannan Sadhasivam
2021-09-15 9:57 ` [PATCH 3/3] mtd: rawnand: qcom: Add support for page scope read Md Sadre Alam
2021-09-28 12:21 ` mdalam
2021-09-28 12:54 ` Miquel Raynal
2021-09-28 16:12 ` Manivannan Sadhasivam
2021-09-28 15:17 ` Manivannan Sadhasivam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210928151737.GA12183@thinkpad \
--to=mani@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=mdalam@codeaurora.org \
--cc=miquel.raynal@bootlin.com \
--cc=sricharan@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).