From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1257AC433EF for ; Mon, 15 Nov 2021 11:37:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D413361C32 for ; Mon, 15 Nov 2021 11:37:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D413361C32 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:CC :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=HM+TnDposeTUny0i+U9+WhBWzMOHzNdF/ZwONWXZbOI=; b=tIFlFtKWLNIjDq 96HRCuChuP5biWyjO4hieJ0qhDeh9QwacxKuMPd63IXDHby6PVO+kYx+SpvvmJOnYEaH8iPapMN2f F40ycr7Yx6h6wXgPHcO3zW5+mCH4sexq8yK1ttHQTOEj5rFOoXO+h1f0jlKvfpAv+bSl2OdVCNJVp H4tjaE0KvNoM7w7h0apbu3ialV28O2PL/zqwEDp1eDSbVQ1HO3kGAr4D8Yzzal1KZezZNzMD6mO+8 FKNOorYRxAIJNqXEpYWbkAEgPHCLF+M0Mg2QwLrapTSrMce57P96MlRqQ9pWdsbKPSUCkxR/jUtnS mU+ufqp7TqG3UNdHdXpw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mmaIR-00FPwe-2B; Mon, 15 Nov 2021 11:37:11 +0000 Received: from mail-bn8nam08on2085.outbound.protection.outlook.com ([40.107.100.85] helo=NAM04-BN8-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mmaIN-00FPuP-8q for linux-mtd@lists.infradead.org; Mon, 15 Nov 2021 11:37:08 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E6aQQ4B7hC6qSsGcpxKcpAKlXRGtqiLGmXwwfXB2KjvttkDKOivQTp8ILJYDWbJAAnn4F1lhY0s2wvLqPMOD2LtcC4pFq9RSwyWbIzhgLvPDAl5tV3H5wTb83JnRd3SeomD8bMr0T20kntQwXADHhawMoR9GJJS1TxoFfzbKXMCVfA0yOBqMQ7M6UR6jg75+SZJKZLnTFmrnAz47bCBulugYhfETGivCK9RK0bwVcDdeOratL6fPjH7SQbv2b07trZD1jaFI9kQ8PH5AN8bdP+vh2Pv56LDWv+GlwODIxhmFNuExpTZVkeSbpozt6NtrYNO9YxoYSE4CZSTCTVG+ZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=e4vTFYd6QSIQnK5LC/9sLqnvD9aLlTuQ+Ax3tdF4uoY=; b=Lpl6rvd6LmSPplW1yCXUkW9o+CwhJOaBbpml/E2wxQ2xzIAorQKOjR9nt+PRmemfpjl4JEIe4Te2BK4NcOS/29mGibttHZq9TQS/eaMadrcYkJdRr6I0EifrQeSpit2/Hn7Yqg+QZnc78JWlcOoXok5yTHC3SF7p2MQvv1aCttZAqLpYlQmRf3DX9FFCP9JeAz8uBDU+EGgRa3CrOjBA0JEdX3Hb4EKGTMdlCNiebWqtXbZGql1Rg2WZ/lpNc4pBf4DhRgQ46k6rQdMgSnVX2DjCrkCiN1heGZIcP9nmvGPi5Iz87peEWS31CzgE5vZH/sGMvRDwg9JKnGrLCTlhTw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.36) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=e4vTFYd6QSIQnK5LC/9sLqnvD9aLlTuQ+Ax3tdF4uoY=; b=Etq+FXa52YLD3FkWEg6NH6BIljOs1++4Fy7lOSFu4rXthnVAlcYm0FAyCOHaT5KLzHVHhlNZlPWl0r1gzNgOOVe8nlH+QdPR9t6z/FckSJIu92T6WIz48K9L9qhdG3PVKkdJQu1Wq91FN2wQdjdExNmAbU61rJSNLW2P+e/cI1WwyfEnAQYI62OX65E7KfKeQH4TDpCXrt6OMOBKWzjYymag/kKzfutEBnTEJaIyh8kCljZ+AYiE3qvtfi2L3fenqPan1Oq+ASAsjeyNcocKd8tCnIg3A5JKPXkKzy48t2twBX8Dr+glzf3BIaIN4jxmysXTrYmbWMnKAnVwJNVRzw== Received: from DM6PR06CA0022.namprd06.prod.outlook.com (2603:10b6:5:120::35) by DM5PR12MB1660.namprd12.prod.outlook.com (2603:10b6:4:9::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.26; Mon, 15 Nov 2021 11:37:02 +0000 Received: from DM6NAM11FT049.eop-nam11.prod.protection.outlook.com (2603:10b6:5:120:cafe::58) by DM6PR06CA0022.outlook.office365.com (2603:10b6:5:120::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.26 via Frontend Transport; Mon, 15 Nov 2021 11:37:02 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.36) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.36 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.36; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.36) by DM6NAM11FT049.mail.protection.outlook.com (10.13.172.188) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4690.15 via Frontend Transport; Mon, 15 Nov 2021 11:37:02 +0000 Received: from HQMAIL105.nvidia.com (172.20.187.12) by HQMAIL101.nvidia.com (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Mon, 15 Nov 2021 11:37:01 +0000 Received: from moonraker.home (172.20.187.5) by mail.nvidia.com (172.20.187.12) with Microsoft SMTP Server id 15.0.1497.18 via Frontend Transport; Mon, 15 Nov 2021 11:37:00 +0000 From: Jon Hunter To: Miquel Raynal , Richard Weinberger , Vignesh Raghavendra CC: , , , Mark Brown , Jon Hunter Subject: [PATCH] mtd: dataflash: Add device-tree SPI IDs Date: Mon, 15 Nov 2021 11:36:55 +0000 Message-ID: <20211115113655.237785-1-jonathanh@nvidia.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-NVConfidentiality: public X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6b364fbb-8494-4ae7-9e0d-08d9a82c3e39 X-MS-TrafficTypeDiagnostic: DM5PR12MB1660: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3631; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rTsZykAPcvfDNUjuwAZ5hac9S26aTAOOMatj/uxJ8DbICMXDbNPigcgFa5M3XAeoFLrpAua4EIPS4snlWz2gcT90hqLmxQ9V2CqKnszJf6nA3Zv3Y3I2eCvUxfBTAXqYIbDQ8S431Wt6dsPHuZm4qCuHOFYL+YtmQT5yt6/OfBPaCSNFqwO3302gN9Wny9zGzEZYjRbHxdI505LhVmfZ6lQh1I+6jxw7hXyetqj/iA1aMV/u1MFEB0+Q2xMCJXZOkPUxcbNSWwIqX1GoN9+qRHf2ia7caOb1yKreD56T9R4flVGOhqAvILVD+iXslGVbWvnTcJDbgZuWePRwFCgu18wqQqSt9VxaNx6pKh26xLl9JB1zRJeLTPXXIoMC1hX5JjfOg1N3URCR4Rze6MdOjLjjR3yCmBZ7ueNYG9Cp+uMekUW+sWXCH0b1Fzpd+pDwlN1ZLpGtPZmllRm1Y85FT9v4eWrabyObruph1yqvSVz4eNl0VHXixarn9SwdWIlBo1SyMBKKPebg/U9N+dJBXKZQDvEqKN/zWe/5zwYRXn6u46l3CsXuO/CZ0sBVaTysYUZEQTSy9MV6ymKBfkwbdsminZscO8srIzPygIEkFU6i1SUQxbusFtqVFU8hAza01c1c17OGE4ZDc8geiSSi+RwpukEQigyc/Um3uoqKfIAc7ReM5wwurWuSq6PrfuYxSy0Gmsucd6L3bph4ITBEyQ== X-Forefront-Antispam-Report: CIP:216.228.112.36; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid05.nvidia.com; CAT:NONE; SFS:(4636009)(46966006)(36840700001)(426003)(8676002)(82310400003)(336012)(4326008)(47076005)(36860700001)(6666004)(2906002)(26005)(186003)(86362001)(8936002)(1076003)(36756003)(356005)(70206006)(107886003)(508600001)(5660300002)(2616005)(70586007)(7636003)(36906005)(54906003)(110136005)(83380400001)(316002); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2021 11:37:02.4397 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6b364fbb-8494-4ae7-9e0d-08d9a82c3e39 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.36]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT049.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1660 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211115_033707_368587_9884DF3A X-CRM114-Status: GOOD ( 12.60 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org Commit 5fa6863ba692 ("spi: Check we have a spi_device_id for each DT compatible") added a test to check that every SPI driver has a spi_device_id for each DT compatiable string defined by the driver and warns if the spi_device_id is missing. The spi_device_ids are missing for the dataflash driver and the following warnings are now seen. WARNING KERN SPI driver mtd_dataflash has no spi_device_id for atmel,at45 WARNING KERN SPI driver mtd_dataflash has no spi_device_id for atmel,dataflash Fix this by adding the necessary spi_device_ids. Signed-off-by: Jon Hunter --- drivers/mtd/devices/mtd_dataflash.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/mtd/devices/mtd_dataflash.c b/drivers/mtd/devices/mtd_dataflash.c index 9802e265fca8..2b317ed6c103 100644 --- a/drivers/mtd/devices/mtd_dataflash.c +++ b/drivers/mtd/devices/mtd_dataflash.c @@ -96,6 +96,13 @@ struct dataflash { struct mtd_info mtd; }; +static const struct spi_device_id dataflash_dev_ids[] = { + { "at45" }, + { "dataflash" }, + { }, +}; +MODULE_DEVICE_TABLE(spi, dataflash_dev_ids); + #ifdef CONFIG_OF static const struct of_device_id dataflash_dt_ids[] = { { .compatible = "atmel,at45", }, @@ -927,6 +934,7 @@ static struct spi_driver dataflash_driver = { .name = "mtd_dataflash", .of_match_table = of_match_ptr(dataflash_dt_ids), }, + .id_table = dataflash_dev_ids, .probe = dataflash_probe, .remove = dataflash_remove, -- 2.25.1 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/