Re: [PATCH v2 01/11] ASoC: tegra20-spdif: stop setting slave_id

Dmitry Osipenko
2021-11-24T17:37:55Z

24.11.2021 19:47, Arnd Bergmann пишет:
> On Wed, Nov 24, 2021 at 5:32 PM Dmitry Osipenko <digetx@gmail.com> wrote:
>> 23.11.2021 01:21, Arnd Bergmann пишет:
>>
>> The commit message is correct, however you could remove even more code
>> here. But there is no need to make a v3 just because this patch because
>> I already prepared patchset that revives this S/PDIF driver and enables
>> HDMI audio on Tegra20. I'll take care of cleaning up the whole code of
>> this driver.
>
> Ok, perfect, thanks for taking a closer look as well.
>
>>
>> - dmareq = platform_get_resource(pdev, IORESOURCE_DMA, 0);
>> - if (!dmareq) {
>> - dev_err(&pdev->dev, "No DMA resource\n");
>> - return -ENODEV;
>> - }
>> -
>
> Right, I think I considered doing this at some point as well, not sure
> why I left it in for the version I posted. Passing the IORESOURCE_DMA
> values is clearly wrong by itself and needs to be removed, though
> it's not obvious what the correct way of requesting the DMA channel
> is for this driver either, without a DT binding or users.

Yes, it's indeed not obvious.