[PATCH v5 05/13] spi: spi-mem: Export the spi_mem_generic_supports_op() helper

Miquel Raynal
2021-12-14T11:45:27Z

The combination of checks against the number of supported operations is
going to increase exponentially each time we add a new parameter. So far
we only had a dtr parameter. Now we are introducing an ECC parameter. We
need to make this helper available for drivers with specific needs,
instead of creating yet another set of helpers each time we want to
check something new. In the future if we see that many different drivers
use the same parameter values, we might be tempted to create a specific
helper for that. But for now, let's just make the generic one
available.

Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
---
drivers/spi/spi-mem.c | 7 ++++---
include/linux/spi/spi-mem.h | 12 ++++++++++++
2 files changed, 16 insertions(+), 3 deletions(-)

diff --git a/drivers/spi/spi-mem.c b/drivers/spi/spi-mem.c
index 4c6944d7b174..df2ec2c8ce31 100644
--- a/drivers/spi/spi-mem.c
+++ b/drivers/spi/spi-mem.c
@@ -160,9 +160,9 @@ static bool spi_mem_check_buswidth(struct spi_mem *mem,
return true;
}

-static bool spi_mem_generic_supports_op(struct spi_mem *mem,
- const struct spi_mem_op *op,
- struct spi_mem_controller_caps *caps)
+bool spi_mem_generic_supports_op(struct spi_mem *mem,
+ const struct spi_mem_op *op,
+ struct spi_mem_controller_caps *caps)
{
if (!caps->dtr) {
if (op->cmd.dtr || op->addr.dtr ||
@@ -178,6 +178,7 @@ static bool spi_mem_generic_supports_op(struct spi_mem *mem,

return spi_mem_check_buswidth(mem, op);
}
+EXPORT_SYMBOL_GPL(spi_mem_generic_supports_op);

bool spi_mem_dtr_supports_op(struct spi_mem *mem,
const struct spi_mem_op *op)
diff --git a/include/linux/spi/spi-mem.h b/include/linux/spi/spi-mem.h
index f365efcfb719..a17dd5035530 100644
--- a/include/linux/spi/spi-mem.h
+++ b/include/linux/spi/spi-mem.h
@@ -325,6 +325,10 @@ void spi_controller_dma_unmap_mem_op_data(struct spi_controller *ctlr,
const struct spi_mem_op *op,
struct sg_table *sg);

+bool spi_mem_generic_supports_op(struct spi_mem *mem,
+ const struct spi_mem_op *op,
+ struct spi_mem_controller_caps *caps);
+
bool spi_mem_default_supports_op(struct spi_mem *mem,
const struct spi_mem_op *op);

@@ -347,6 +351,14 @@ spi_controller_dma_unmap_mem_op_data(struct spi_controller *ctlr,
{
}

+static inline
+bool spi_mem_generic_supports_op(struct spi_mem *mem,
+ const struct spi_mem_op *op,
+ struct spi_mem_controller_caps *caps)
+{
+ return false;
+}
+
static inline
bool spi_mem_default_supports_op(struct spi_mem *mem,
const struct spi_mem_op *op)
--
2.27.0