From: Dan Carpenter <dan.carpenter@oracle.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Joern Engel <joern@lazybastard.org>,
yangerkun <yangerkun@huawei.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
linux-mtd@lists.infradead.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] mtd: phram: Prevent divide by zero bug in phram_setup()
Date: Fri, 21 Jan 2022 14:51:03 +0300 [thread overview]
Message-ID: <20220121115103.GH1978@kadam> (raw)
In-Reply-To: <20220121121748.24e98015@xps13>
On Fri, Jan 21, 2022 at 12:17:48PM +0100, Miquel Raynal wrote:
> Hi Dan,
>
> dan.carpenter@oracle.com wrote on Fri, 21 Jan 2022 08:38:36 +0300:
>
> > The problem is that "erasesize" is a uint32_t type so it might be
>
> Don't you mean uint64_t here? Otherwise I don't get the sentence.
>
Yeah. I meant uint64_t. Will resend.
> > non-zero but the truncated "(uint32_t)erasesize" value *is* zero. That
>
> s/*is*/*can* be/ ? (again, if my understanding is correct).
>
It might be a situation where "erasesize" is non-zero but after we
truncated it "(uint32_t)erasesize" is zero.
> > would lead to the divide by zero bug.
> >
> > Avoid the bug by delaying the divide until after we have validated
> > that "erasesize" is reasonable.
>
> I don't really get the fix. If "erasesize" is big enough, then
> (uint32_t)erasesize can however be zero. But checking if erasesize is
> zero beforehands does not fix the situation. Or am I missing
> something?
It doesn't just check for zero, it checks a couple other things
including if erasesize > UINT_MAX.
regards,
dan carpenter
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2022-01-21 11:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-21 5:38 [PATCH] mtd: phram: Prevent divide by zero bug in phram_setup() Dan Carpenter
2022-01-21 11:17 ` Miquel Raynal
2022-01-21 11:51 ` Dan Carpenter [this message]
2022-01-22 2:43 ` yangerkun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220121115103.GH1978@kadam \
--to=dan.carpenter@oracle.com \
--cc=joern@lazybastard.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
--cc=yangerkun@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).