linux-mtd.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: david regan <dregan@mail.com>,
	linux-mtd@lists.infradead.org, Kamal Dasu <kdasu.kdev@gmail.com>,
	Joel Peshkin <joel.peshkin@broadcom.com>
Subject: Re: [PATCH] mtd: rawnand: brcmnand: Fixed incorrect sub-page ECC status
Date: Wed, 26 Jan 2022 10:47:46 +0100	[thread overview]
Message-ID: <20220126104746.225eb894@xps13> (raw)
In-Reply-To: <5ea1a3c7-a8fa-f88e-7575-8d8e96833398@gmail.com>

Hi David,

f.fainelli@gmail.com wrote on Tue, 25 Jan 2022 10:59:19 -0800:

> +Miquel,
> 
> On 1/12/2022 1:08 PM, david regan wrote:
> > The brcmnand driver contains a bug in which if a page (example 2k byte)
> > is read from the parallel/ONFI NAND and within that page a subpage (512
> > byte) has correctable errors which is followed by a subpage with
> > uncorrectable errors, the page read will return the wrong status of
> > correctable (as opposed to the actual status of uncorrectable.)
> > 
> > The bug is in function brcmnand_read_by_pio where there is a check for
> > uncorrectable bits which will be preempted if a previous status for
> > correctable bits is detected.
> > 
> > The fix is to stop checking for bad bits only if we already have a bad
> > bits status.
> > 
> > Fixes: 27c5b17cd1b1 ("mtd: nand: add NAND driver "library" for Broadcom STB NAND controller")
> > 
> > Signed-off-by: david regan <dregan@mail.com>  
> 
> Miquel since you were not copied explicitly, adding you now. Re-sending my tag:
> 
> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>

This change does not apply to my tree, please look at the series from
Florian on nand/next (kernel.org repository named mtd). If it conflicts
with your fix, then rebase on top of nand/next. Otherwise please rebase
on top of mtd/fixes.

And don't forget to keep the Reviewed-by tag from Florian and to keep
me in To/Cc of your v2.

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

      parent reply	other threads:[~2022-01-26  9:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-12 21:08 [PATCH] mtd: rawnand: brcmnand: Fixed incorrect sub-page ECC status david regan
2022-01-13  4:58 ` Florian Fainelli
2022-01-25 18:59 ` Florian Fainelli
2022-01-26  9:10   ` Miquel Raynal
2022-01-26  9:47   ` Miquel Raynal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220126104746.225eb894@xps13 \
    --to=miquel.raynal@bootlin.com \
    --cc=dregan@mail.com \
    --cc=f.fainelli@gmail.com \
    --cc=joel.peshkin@broadcom.com \
    --cc=kdasu.kdev@gmail.com \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).