From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Tokunori Ikegami <ikegami.t@gmail.com>
Cc: linux-mtd@lists.infradead.org,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>
Subject: Re: [PATCH v3 1/3] mtd: cfi_cmdset_0002: Add S29GL064N ID definition
Date: Tue, 15 Mar 2022 19:37:40 +0100 [thread overview]
Message-ID: <20220315193740.23284a20@xps13> (raw)
In-Reply-To: <20220315165607.390070-2-ikegami.t@gmail.com>
Hi Tokunori,
ikegami.t@gmail.com wrote on Wed, 16 Mar 2022 01:56:05 +0900:
> It is for the model number 01, 02, V1 and V2.
Please move this change to the end of the series. We do not need to
backport this improvement.
Also use the hexadecimal value in your fix (patch 3/3) so that we can
apply it easily to older kernels.
> Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
> Cc: Miquel Raynal <miquel.raynal@bootlin.com>
> Cc: Richard Weinberger <richard@nod.at>
> Cc: Vignesh Raghavendra <vigneshr@ti.com>
> Cc: linux-mtd@lists.infradead.org
> ---
> drivers/mtd/chips/cfi_cmdset_0002.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/chips/cfi_cmdset_0002.c b/drivers/mtd/chips/cfi_cmdset_0002.c
> index a761134fd3be..0125658a1d30 100644
> --- a/drivers/mtd/chips/cfi_cmdset_0002.c
> +++ b/drivers/mtd/chips/cfi_cmdset_0002.c
> @@ -48,6 +48,7 @@
> #define SST49LF040B 0x0050
> #define SST49LF008A 0x005a
> #define AT49BV6416 0x00d6
> +#define S29GL064N_MN12 0x0c01
>
> /*
> * Status Register bit description. Used by flash devices that don't
> @@ -462,7 +463,7 @@ static struct cfi_fixup cfi_fixup_table[] = {
> { CFI_MFR_AMD, 0x0056, fixup_use_secsi },
> { CFI_MFR_AMD, 0x005C, fixup_use_secsi },
> { CFI_MFR_AMD, 0x005F, fixup_use_secsi },
> - { CFI_MFR_AMD, 0x0c01, fixup_s29gl064n_sectors },
> + { CFI_MFR_AMD, S29GL064N_MN12, fixup_s29gl064n_sectors },
> { CFI_MFR_AMD, 0x1301, fixup_s29gl064n_sectors },
> { CFI_MFR_AMD, 0x1a00, fixup_s29gl032n_sectors },
> { CFI_MFR_AMD, 0x1a01, fixup_s29gl032n_sectors },
Thanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2022-03-15 18:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-15 16:56 [PATCH v3 0/3] mtd: cfi_cmdset_0002: Use chip_ready() for write on S29GL064N Tokunori Ikegami
2022-03-15 16:56 ` [PATCH v3 1/3] mtd: cfi_cmdset_0002: Add S29GL064N ID definition Tokunori Ikegami
2022-03-15 18:37 ` Miquel Raynal [this message]
2022-03-16 15:56 ` Tokunori Ikegami
2022-03-15 16:56 ` [PATCH v3 2/3] mtd: cfi_cmdset_0002: Move and rename chip_check/chip_ready/chip_good_for_write Tokunori Ikegami
2022-03-15 18:44 ` Miquel Raynal
2022-03-16 16:04 ` Tokunori Ikegami
2022-03-15 16:56 ` [PATCH v3 3/3] mtd: cfi_cmdset_0002: Use chip_ready() for write on S29GL064N Tokunori Ikegami
2022-03-15 18:51 ` Miquel Raynal
2022-03-16 16:05 ` Tokunori Ikegami
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220315193740.23284a20@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=ikegami.t@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox