public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Jean-Marc Eurin <jmeurin@google.com>
Cc: Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Create a proper header for the saved mtdoops.
Date: Wed, 30 Mar 2022 09:34:21 +0200	[thread overview]
Message-ID: <20220330093421.35de104d@xps13> (raw)
In-Reply-To: <20220329225328.396209-1-jmeurin@google.com>

Hi Jean-Marc,

jmeurin@google.com wrote on Tue, 29 Mar 2022 15:53:28 -0700:

> Avoid a panic if the header size changes.
> Add a timestamp to the oops header.
> 
> Tested:
> Triggered panic saved correctly:
> xxd -l 0x20 -s 0x0000 /dev/mtdblock1
> 00000000: 0100 0000 005e 005d 935d 4117 c5bf df16  .....^.].]A.....
> 00000010: 3c36 3e5b 2020 3133 392e 3938 3039 3533  <6>[  139.980953

Your previous patchset was not applied because I requested several
changes, yet you seem not to have taken them into account. For the
record:

	Can you please send a v2 with:
	- Your two patches in the same series (formatted with
	  git-format-patch to get the dependency/order right)
	- In the other commit, drop the reference pointing to (I
	  believe) a commit hash that is local to your tree only.
	- Use the right prefix ("mtd: mtdoops:").

If you are fixing something different then create another patch in this
series, but please keep you changes atomic and well separated, include
a changelog and use proper subject prefixes.

Thanks,
Miquèl


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

      reply	other threads:[~2022-03-30  7:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-29 22:53 [PATCH] Create a proper header for the saved mtdoops Jean-Marc Eurin
2022-03-30  7:34 ` Miquel Raynal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220330093421.35de104d@xps13 \
    --to=miquel.raynal@bootlin.com \
    --cc=jmeurin@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=richard@nod.at \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox