public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Han Xu <han.xu@nxp.com>
Cc: sean@geanix.com, frieder.schrempf@kontron.de, festevam@gmail.com,
	ye.li@nxp.com, peng.fan@nxp.com, linux-mtd@lists.infradead.org
Subject: Re: [PATCH v3 3/4] mtd: rawnand: gpmi: Rename the variable ecc_chunk_size
Date: Tue, 5 Apr 2022 09:29:49 +0200	[thread overview]
Message-ID: <20220405092949.448ca3d5@xps13> (raw)
In-Reply-To: <20220404195427.8871-3-han.xu@nxp.com>

Hi Han,

han.xu@nxp.com wrote on Mon,  4 Apr 2022 14:54:26 -0500:

> There is only one variable ecc_chunk_size in bch_geometry data
> structure but two different field in BCH registers. The data0_size in
> BCH_FLASH0LAYOUT0 and datan_size in BCH_FLASH0LAYOUT1 should have
> dedicate variable since they might set to different values in some
> cases.

Great, thanks.

I assume this patch brings no functional change and should not be
expected to bring any regression. If so, can you please state it in the
commit log?

> 
> Signed-off-by: Han Xu <han.xu@nxp.com>
> 

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2022-04-05  7:34 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-04 19:54 [PATCH v3 1/4] mtd: rawnand: gpmi: Refactor bch geometry settings function Han Xu
2022-04-04 19:54 ` [PATCH v3 2/4] mtd: rawnand: gpmi: Add strict ecc strength check Han Xu
2022-04-05  7:28   ` Miquel Raynal
2022-04-08 22:05     ` Han Xu
2022-04-11  7:30       ` Miquel Raynal
2022-04-04 19:54 ` [PATCH v3 3/4] mtd: rawnand: gpmi: Rename the variable ecc_chunk_size Han Xu
2022-04-05  7:29   ` Miquel Raynal [this message]
2022-04-04 19:54 ` [PATCH v3 4/4] mtd: rawnand: gpmi: Add large oob bch setting support Han Xu
2022-04-05  7:26 ` [PATCH v3 1/4] mtd: rawnand: gpmi: Refactor bch geometry settings function Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220405092949.448ca3d5@xps13 \
    --to=miquel.raynal@bootlin.com \
    --cc=festevam@gmail.com \
    --cc=frieder.schrempf@kontron.de \
    --cc=han.xu@nxp.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=peng.fan@nxp.com \
    --cc=sean@geanix.com \
    --cc=ye.li@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox