Re: [PATCH v6 0/5] spi: add support for Mediatek SPI-NAND controller

Miquel Raynal
2022-04-27T09:29:56Z

Hi Mark,

gch981213@gmail.com wrote on Sun, 24 Apr 2022 11:25:22 +0800:

> Mediatek has an extended version of their NAND Flash Interface which
> has a SPI-NAND mode. In this mode, the controller can perform 1-bit
> spi-mem ops for up-to 0xa0 bytes and typical SPI-NAND single, dual
> and quad IO page cache ops with 2-byte address. Additionally, the
> page cache ops can be performed with ECC and auto data formatting
> using the ECC engine of the controller.
>
> This patchset implements support of this mode as a separated SPI-MEM
> driver with pipelined ECC engine.

[...]

The patch actually look independent, so if it's fine for you I can take
the two mtd patches and let you merge the spi/binding changes.

Would this work for you?

> Chuanhong Guo (5):
> mtd: nand: make mtk_ecc.c a separated module
> spi: add driver for MTK SPI NAND Flash Interface
> mtd: nand: mtk-ecc: also parse nand-ecc-engine if available
> spi: dt-bindings: add binding doc for spi-mtk-snfi
> arm64: dts: mediatek: add mtk-snfi for mt7622
>
> .../bindings/spi/mediatek,spi-mtk-snfi.yaml | 88 +
> arch/arm64/boot/dts/mediatek/mt7622.dtsi | 12 +
> drivers/mtd/nand/Kconfig | 7 +
> drivers/mtd/nand/Makefile | 1 +
> drivers/mtd/nand/{raw/mtk_ecc.c => ecc-mtk.c} | 8 +-
> drivers/mtd/nand/raw/Kconfig | 1 +
> drivers/mtd/nand/raw/Makefile | 2 +-
> drivers/mtd/nand/raw/mtk_nand.c | 2 +-
> drivers/spi/Kconfig | 10 +
> drivers/spi/Makefile | 1 +
> drivers/spi/spi-mtk-snfi.c | 1470 +++++++++++++++++
> .../linux/mtd/nand-ecc-mtk.h | 0
> 12 files changed, 1597 insertions(+), 5 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/spi/mediatek,spi-mtk-snfi.yaml
> rename drivers/mtd/nand/{raw/mtk_ecc.c => ecc-mtk.c} (98%)
> create mode 100644 drivers/spi/spi-mtk-snfi.c
> rename drivers/mtd/nand/raw/mtk_ecc.h => include/linux/mtd/nand-ecc-mtk.h (100%)
>

Thanks,
Miquèl