From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Rickard Andersson <rickaran@axis.com>
Cc: <richard@nod.at>, <linux-mtd@lists.infradead.org>,
<rickard314.andersson@gmail.com>
Subject: Re: [PATCH] MTD: NAND: Select timings for Kioxia TH58NVG3S0HBAI4
Date: Fri, 29 Apr 2022 10:16:38 +0200 [thread overview]
Message-ID: <20220429101638.14719910@xps13> (raw)
In-Reply-To: <20220429080549.29236-1-rickaran@axis.com>
Hi Rickard,
rickaran@axis.com wrote on Fri, 29 Apr 2022 10:05:49 +0200:
> From: Rickard x Andersson <rickaran@axis.com>
>
> Add timings for Kioxia/Toshiba TH58NVG3S0HBAI4. Timings
> for this memory matches the timings selected for
> TH58NVG2S3HBAI4.
>
> This patch increases eraseblock write speed from 5248 KiB/s
> to 6864 KiB/s and erase block read speed from 8542 KiB/s
> to 18360 KiB/s
>
> Tested on i.MX6SX.
Please change the title to something like:
"mtd: rawnand: kioxia: Add support for TH58NVG3S0HBAI4"
And we'll be good.
>
> Signed-off-by: Rickard x Andersson <rickaran@axis.com>
> ---
> drivers/mtd/nand/raw/nand_ids.c | 3 +++
> drivers/mtd/nand/raw/nand_toshiba.c | 6 ++++--
> 2 files changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/nand/raw/nand_ids.c b/drivers/mtd/nand/raw/nand_ids.c
> index d64adbd1ce6b..88c2440b47d8 100644
> --- a/drivers/mtd/nand/raw/nand_ids.c
> +++ b/drivers/mtd/nand/raw/nand_ids.c
> @@ -61,6 +61,9 @@ struct nand_flash_dev nand_flash_ids[] = {
> {"TH58NVG2S3HBAI4 4G 3.3V 8-bit",
> { .id = {0x98, 0xdc, 0x91, 0x15, 0x76} },
> SZ_2K, SZ_512, SZ_128K, 0, 5, 128, NAND_ECC_INFO(8, SZ_512) },
> + {"TH58NVG3S0HBAI4 8G 3.3V 8-bit",
> + { .id = {0x98, 0xd3, 0x91, 0x26, 0x76} },
> + SZ_4K, SZ_1K, SZ_256K, 0, 5, 256, NAND_ECC_INFO(8, SZ_512)},
>
> LEGACY_ID_NAND("NAND 4MiB 5V 8-bit", 0x6B, 4, SZ_8K, SP_OPTIONS),
> LEGACY_ID_NAND("NAND 4MiB 3,3V 8-bit", 0xE3, 4, SZ_8K, SP_OPTIONS),
> diff --git a/drivers/mtd/nand/raw/nand_toshiba.c b/drivers/mtd/nand/raw/nand_toshiba.c
> index cf4f37959421..d3d34d71921f 100644
> --- a/drivers/mtd/nand/raw/nand_toshiba.c
> +++ b/drivers/mtd/nand/raw/nand_toshiba.c
> @@ -287,8 +287,10 @@ static int toshiba_nand_init(struct nand_chip *chip)
> if (!strncmp("TC58NVG0S3E", chip->parameters.model,
> sizeof("TC58NVG0S3E") - 1))
> tc58nvg0s3e_init(chip);
> - if (!strncmp("TH58NVG2S3HBAI4", chip->parameters.model,
> - sizeof("TH58NVG2S3HBAI4") - 1))
> + if ((!strncmp("TH58NVG2S3HBAI4", chip->parameters.model,
> + sizeof("TH58NVG2S3HBAI4") - 1)) ||
> + (!strncmp("TH58NVG3S0HBAI4", chip->parameters.model,
> + sizeof("TH58NVG3S0HBAI4") - 1)))
> th58nvg2s3hbai4_init(chip);
>
> return 0;
Thanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
prev parent reply other threads:[~2022-04-29 8:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-29 8:05 [PATCH] MTD: NAND: Select timings for Kioxia TH58NVG3S0HBAI4 Rickard Andersson
2022-04-29 8:16 ` Miquel Raynal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220429101638.14719910@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
--cc=rickaran@axis.com \
--cc=rickard314.andersson@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox