From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0DED7C433F5 for ; Tue, 3 May 2022 08:17:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:CC :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=ILbUXWHW43GGnSwQK9Q+IjvmJ+Ov9WFiuFTOQEvb7Xc=; b=kHeVowLhX2+f1G svhctcGCemkVOeH0hLWcMCW3iRLoV68HXbGHtUUPSuORhe+Y2mCJWIujrQrd6DBCzsY1dy8Va7nXA ITwX/axnrb1yxkS4P52piehBktvOg770Ma6iQlHn/dmqTdX5f8DIon8Ne1+bZwoOJ9UZEEAf/2dqy VazLz0FjTkQ+atYq81OQIxiEcIUZ8jnPH/h4UIX9aewTRCdUSG2D6lFk8X4HfxlBvsL41OFPI2/QV ImBGWdxPgKHsmX1lzsPSihNv1H5kCuBrKnZ7hYxaHF6x5Io7mdS53bj2LZVvKVWZ91oEKoWXlYNug Pa8oJbTSvkQw2mXsQ2EQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nlni3-004ZER-80; Tue, 03 May 2022 08:16:39 +0000 Received: from esa.microchip.iphmx.com ([68.232.153.233]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nlnhz-004ZDK-CA for linux-mtd@lists.infradead.org; Tue, 03 May 2022 08:16:38 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1651565795; x=1683101795; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=mxiyzXBJwnE/VEq63e2GjemVpLDPBD7Md+dy4O7AIqM=; b=GQwWl8daUJ4mxyYD1Cqiew63JXLJmYJXFS2UlVBiN7nWbpxa6ZwO/nvW WSY5L0vupUoYppWQzoSSJRKtawx7vwldG8/LlLi5Cyf/jZGuBoYrRQsT6 dTajNNa6w9+H7St3Hi1wek2CgXlcq7LPfsyhW4F7SamJu8IvqtRZ/tSWM VQ2iJEWffrzC9hqGxmlyQDSSAOeqFtUSRaUL3wNPu+d46jrY0dws44nzN h1KMHrZoomrLz2mxWy85m6PsgdD6M+GaHEUMV5DApfryz2gvnHKjHv6pG B8FewQ6cV20VbAiWfXG7vJcQXpuzbiwi1NKPDlmYZN/7OddE6ifkR6/XS Q==; X-IronPort-AV: E=Sophos;i="5.91,194,1647327600"; d="scan'208";a="171740299" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa1.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 03 May 2022 01:16:31 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17; Tue, 3 May 2022 01:16:31 -0700 Received: from ROB-ULT-M18064N.mchp-main.com (10.10.115.15) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server id 15.1.2375.17 via Frontend Transport; Tue, 3 May 2022 01:16:29 -0700 From: Tudor Ambarus To: , , CC: , , , , , Tudor Ambarus Subject: [PATCH v14 0/8] mtd: spi-nor: Add support for Infineon s25hl-t/s25hs-t Date: Tue, 3 May 2022 11:16:19 +0300 Message-ID: <20220503081627.341870-1-tudor.ambarus@microchip.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220503_011635_511832_E024328C X-CRM114-Status: GOOD ( 17.76 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org Hi, Takahiro, Would you please test this series? It's only compiled tested on my side. Cheers, ta --- Changes in v14: - add prerequisite patches for s25hl-t/s25hs-t addition. - squash volatile quad enable method to the patch that adds the flashes to avoid unused function warning. Changes in v13: - Remove patch, Call set_4byte_addr_mode() before spi_nor_quad_enalbe() - Remove patch, Rename local macro - Use 3-byte address width in cypress_nor_quad_enable_volatile() - Add post_sfdp to fix 3 byte erase opcode in 4BAIT Changes in v12: - Rebase on top of Tudor's series https://patchwork.ozlabs.org/project/linux-mtd/list/?series=295933 https://patchwork.ozlabs.org/project/linux-mtd/list/?series=294533 - New patch: Retain nor->addr_width at 4BAIT parse - New patch: Call set_4byte_addr_mode() before spi_nor_quad_enalbe() - New patch: Rename local macro Changes in v11: - Rebase on top of Tudor's series https://patchwork.ozlabs.org/project/linux-mtd/list/?series=294490 - Remove 'nor->info->addr_width for SMPT parse' patch Changes in v10: - Rebase to v5.18-rc1 - Remove dependencies on other series - Use nor->info->addr_width for SMPT parse - Add a local function for page size discovery - Clean up volatile QE function Changes in v9: - Rebase to v5.17-rc6 - Rename function and macro per mwalle's series - Fix some issues in ID table and fixup hook Changes in v8: - Rebase to v5.17-rc4 - Use spi_nor_read_reg and spi_nor_write_reg() Changes in v7: - Some changes were missing in v6 patch. Fix it Changes in v6: - Remove 2Gb dual die package parts and related changes to split mulit die package support into another series of patches Changes in v5: - Fix 'if (ret == 1)' to 'if (ret < 0)' in spansion_read_any_reg() - Add NO_CHIP_ERASE flag to S25HL02GT and S25HS02GT Changes in v4: - Reword 'legacy' to 'default' - Rename spi_nor_read() to spi_nor_default_ready() - Fix dummy cycle calculation in spansion_read_any_reg() - Modify comment for spansion_write_any_reg() - Merge block comments about SMPT in s25hx_t_post_sfdp_fixups() - Remove USE_CLSR flags from S25HL02GT and S25HS02GT Changes in v3: - Split into multiple patches - Remove S25HL256T and S25HS256T - Add S25HL02GT and S25HS02GT - Add support for multi-die package parts support - Cleanup Read/Write Any Register implementation - Remove erase_map fix for top/split sector layout - Set ECC data unit size (16B) to writesize Changes in v2: - Remove SPI_NOR_SKIP_SFDP flag and clean up related fixups - Check CFR3V[4] to determine page_size instead of force 512B - Depend on the patchset below to support non-uniform sector layout https://lore.kernel.org/linux-mtd/cover.1601612872.git.Takahiro.Kuwano@infineon.com/ The S25HL-T/S25HS-T family is the Infineon SEMPER Flash with Quad SPI. The datasheets can be found in the following link. https://www.infineon.com/dgdl/Infineon-S25HS256T_S25HS512T_S25HS01GT_S25HL256T_S25HL512T_S25HL01GT_256-Mb_(32-MB)_512-Mb_(64-MB)_1-Gb_(128-MB)_HS-T_(1.8-V)_HL-T_(3.0-V)_Semper_Flash_with_Quad_SPI-DataSheet-v02_00-EN.pdf?fileId=8ac78c8c7d0d8da4017d0ee674b86ee3&da=t Device ID, SFDP, and test script output: ------------------------------------------------------------ zynq> cat /sys/bus/spi/devices/spi0.0/spi-nor/partname s25hl512t zynq> cat /sys/bus/spi/devices/spi0.0/spi-nor/jedec_id 342a1a0f0390 zynq> cat /sys/bus/spi/devices/spi0.0/spi-nor/manufacturer spansion zynq> xxd -p /sys/bus/spi/devices/spi0.0/spi-nor/sfdp 53464450080103ff00000114000100ff84000102500100ff81000116c801 00ff8700011c580100ffffffffffffffffffffffffffffffffffffffffff ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff ffffffffffffffffffffffffffffffffe720faffffffff1f48eb086b00ff 88bbfeffffffffff00ffffff48eb0c2000ff00ff12d823faff8b82e7ffe3 ec031c608a857a75f766805c8cd6ddfff938f8a1000000000000bc000000 0000f7f5ffff7b920ffe21ffffdc0000800000000000c0ffc3ebc8ffe3eb 00650090060500a10065009600650095716503d0716503d000000000b02e 000088a489aa716503967165039600000000000000000000000000000000 000000000000000000000000000000000000000000000000716505d57165 05d50000a015fc65ff0804008000fc65ff4002008000fd65ff0402008000 fe0002fff1ff0100f8ff0100f8fffb03fe0302fff8fffb03f8ff0100f1ff 0100fe0104fff1ff0000f8ff0200f8fff703f8ff0200f1ff0000ff0400ff f8ffff03 zynq> md5sum /sys/bus/spi/devices/spi0.0/spi-nor/sfdp 8a0aa90112e154ae3a797df2c211ef61 /sys/bus/spi/devices/spi0.0/spi-nor/sfdp zynq> test_qspi.sh 6+0 records in 6+0 records out 6291456 bytes (6.0MB) copied, 0.223713 seconds, 26.8MB/s Copied 6291456 bytes from qspi_test to address 0x00000000 in flash Erased 6291456 bytes from address 0x00000000 in flash Copied 6291456 bytes from address 0x00000000 in flash to qspi_read 0000000 ffff ffff ffff ffff ffff ffff ffff ffff * 0600000 Copied 6291456 bytes from qspi_test to address 0x00000000 in flash Copied 6291456 bytes from address 0x00000000 in flash to qspi_read 97c13104ef8e1f895d72c64b99233c57730ec773 qspi_test 97c13104ef8e1f895d72c64b99233c57730ec773 qspi_read ------------------------------------------------------------ ------------------------------------------------------------ zynq> cat /sys/bus/spi/devices/spi0.0/spi-nor/partname s25hs512t zynq> cat /sys/bus/spi/devices/spi0.0/spi-nor/jedec_id 342b1a0f0390 zynq> cat /sys/bus/spi/devices/spi0.0/spi-nor/manufacturer spansion zynq> xxd -p /sys/bus/spi/devices/spi0.0/spi-nor/sfdp 53464450080103ff00000114000100ff84000102500100ff81000116c801 00ff8700011c580100ffffffffffffffffffffffffffffffffffffffffff ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff ffffffffffffffffffffffffffffffffe720faffffffff1f48eb086b00ff 88bbfeffffffffff00ffffff48eb0c2000ff00ff12d823faff8b91e8ffe3 ec031c608a857a75f766805c84d6ddfff938f8a100000000000080000000 0000f7f5ffff7b920ffe20ffffd80000800000000000c0ffc3ebc8ffe3eb 00650090060500a10065009600650095716503d0716503d000000000b02e 000088a489aa716503967165039600000000000000000000000000000000 000000000000000000000000000000000000000000000000716505d57165 05d50000ee72fc65ff0804008000fc65ff4002008000fd65ff0402008000 fe0002fff1ff0100f8ff0100f8fffb03fe0302fff8fffb03f8ff0100f1ff 0100fe0104fff1ff0100f8ff0200f8fff703f8ff0200f1ff0100ff0400ff f8ffff03 zynq> md5sum /sys/bus/spi/devices/spi0.0/spi-nor/sfdp f17d9e784602187a0933edec3688e30f /sys/bus/spi/devices/spi0.0/spi-nor/sfdp zynq> test_qspi.sh 6+0 records in 6+0 records out 6291456 bytes (6.0MB) copied, 0.222716 seconds, 26.9MB/s Copied 6291456 bytes from qspi_test to address 0x00000000 in flash Erased 6291456 bytes from address 0x00000000 in flash Copied 6291456 bytes from address 0x00000000 in flash to qspi_read 0000000 ffff ffff ffff ffff ffff ffff ffff ffff * 0600000 Copied 6291456 bytes from qspi_test to address 0x00000000 in flash Copied 6291456 bytes from address 0x00000000 in flash to qspi_read 000b392ab4cca7e2be97c68842794a9b10f3f8a3 qspi_test 000b392ab4cca7e2be97c68842794a9b10f3f8a3 qspi_read ------------------------------------------------------------ ------------------------------------------------------------ zynq> cat /sys/bus/spi/devices/spi0.0/spi-nor/partname s25hl01gt zynq> cat /sys/bus/spi/devices/spi0.0/spi-nor/jedec_id 342a1b0f0390 zynq> cat /sys/bus/spi/devices/spi0.0/spi-nor/manufacturer spansion zynq> xxd -p /sys/bus/spi/devices/spi0.0/spi-nor/sfdp 53464450080103ff00000114000100ff84000102500100ff81000116c801 00ff8700011c580100ffffffffffffffffffffffffffffffffffffffffff ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff ffffffffffffffffffffffffffffffffe720faffffffff3f48eb086b00ff 88bbfeffffffffff00ffffff48eb0c2000ff00ff12d823faff8b82e7ffe6 ec031c608a857a75f766805c8cd6ddfff938f8a1000000000000bc000000 0000f7f5ffff7b920ffe21ffffdc0000800000000000c0ffc3ebc8ffe3eb 00650090060500a10065009600650095716503d0716503d000000000b02e 000088a489aa716503967165039600000000000000000000000000000000 000000000000000000000000000000000000000000000000716505d57165 05d50000a015fc65ff0804008000fc65ff4002008000fd65ff0402008000 fe0002fff1ff0100f8ff0100f8fffb07fe0302fff8fffb07f8ff0100f1ff 0100fe0104fff1ff0000f8ff0200f8fff707f8ff0200f1ff0000ff0400ff f8ffff07 zynq> md5sum /sys/bus/spi/devices/spi0.0/spi-nor/sfdp 1ad5a0d7d7e0e656986c1e678c416a7e /sys/bus/spi/devices/spi0.0/spi-nor/sfdp zynq> test_qspi.sh 6+0 records in 6+0 records out 6291456 bytes (6.0MB) copied, 0.223581 seconds, 26.8MB/s Copied 6291456 bytes from qspi_test to address 0x00000000 in flash Erased 6291456 bytes from address 0x00000000 in flash Copied 6291456 bytes from address 0x00000000 in flash to qspi_read 0000000 ffff ffff ffff ffff ffff ffff ffff ffff * 0600000 Copied 6291456 bytes from qspi_test to address 0x00000000 in flash Copied 6291456 bytes from address 0x00000000 in flash to qspi_read e5396eabcb16cbba29aa3270d7aac6c505e6d5e2 qspi_test e5396eabcb16cbba29aa3270d7aac6c505e6d5e2 qspi_read ------------------------------------------------------------ ------------------------------------------------------------ zynq> cat /sys/bus/spi/devices/spi0.0/spi-nor/partname s25hs01gt zynq> cat /sys/bus/spi/devices/spi0.0/spi-nor/jedec_id 342b1b0f0390 zynq> cat /sys/bus/spi/devices/spi0.0/spi-nor/manufacturer spansion zynq> xxd -p /sys/bus/spi/devices/spi0.0/spi-nor/sfdp 53464450080103ff00000114000100ff84000102500100ff81000116c801 00ff8700011c580100ffffffffffffffffffffffffffffffffffffffffff ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff ffffffffffffffffffffffffffffffffe720faffffffff3f48eb086b00ff 88bbfeffffffffff00ffffff48eb0c2000ff00ff12d823faff8b82e7ffe6 ec031c608a857a75f766805c8cd6ddfff938f8a1000000000000bc000000 0000f7f5ffff7b920ffe21ffffdc0000800000000000c0ffc3ebc8ffe3eb 00650090060500a10065009600650095716503d0716503d000000000b02e 000088a489aa716503967165039600000000000000000000000000000000 000000000000000000000000000000000000000000000000716505d57165 05d50000a015fc65ff0804008000fc65ff4002008000fd65ff0402008000 fe0002fff1ff0100f8ff0100f8fffb07fe0302fff8fffb07f8ff0100f1ff 0100fe0104fff1ff0000f8ff0200f8fff707f8ff0200f1ff0000ff0400ff f8ffff07 zynq> md5sum /sys/bus/spi/devices/spi0.0/spi-nor/sfdp 1ad5a0d7d7e0e656986c1e678c416a7e /sys/bus/spi/devices/spi0.0/spi-nor/sfdp zynq> test_qspi.sh 6+0 records in 6+0 records out 6291456 bytes (6.0MB) copied, 0.223877 seconds, 26.8MB/s Copied 6291456 bytes from qspi_test to address 0x00000000 in flash Erased 6291456 bytes from address 0x00000000 in flash Copied 6291456 bytes from address 0x00000000 in flash to qspi_read 0000000 ffff ffff ffff ffff ffff ffff ffff ffff * 0600000 Copied 6291456 bytes from qspi_test to address 0x00000000 in flash Copied 6291456 bytes from address 0x00000000 in flash to qspi_read 4c2f38951f5c524b2e269e535c7efb93ef5a80dc qspi_test 4c2f38951f5c524b2e269e535c7efb93ef5a80dc qspi_read ------------------------------------------------------------ Takahiro Kuwano (3): mtd: spi-nor: Retain nor->addr_width at 4BAIT parse mtd: spi-nor: spansion: Add local function to discover page size mtd: spi-nor: spansion: Add s25hl-t/s25hs-t IDs and fixups Tudor Ambarus (5): mtd: spi-nor: s/addr_width/addr_nbytes mtd: spi-nor: core: Shrink the storage size of the flash_info's addr_nbytes mtd: spi-nor: sfdp: Clarify that nor->read_{opcode, dummy} are uninitialized mtd: spi-nor: Do not change nor->addr_nbytes at SFDP parsing time mtd: spi-nor: core: Couple the number of address bytes with the address mode drivers/mtd/spi-nor/controllers/aspeed-smc.c | 6 +- drivers/mtd/spi-nor/controllers/hisi-sfc.c | 2 +- drivers/mtd/spi-nor/controllers/nxp-spifi.c | 8 +- drivers/mtd/spi-nor/core.c | 155 ++++++++-------- drivers/mtd/spi-nor/core.h | 14 +- drivers/mtd/spi-nor/issi.c | 2 +- drivers/mtd/spi-nor/otp.c | 12 +- drivers/mtd/spi-nor/sfdp.c | 43 ++--- drivers/mtd/spi-nor/spansion.c | 179 ++++++++++++++++--- drivers/mtd/spi-nor/xilinx.c | 2 +- include/linux/mtd/spi-nor.h | 4 +- 11 files changed, 281 insertions(+), 146 deletions(-) -- 2.25.1 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/