From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Peng Wu <wupeng58@huawei.com>
Cc: <richard@nod.at>, <vigneshr@ti.com>,
<christophe.jaillet@wanadoo.fr>, <linux-mtd@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <liwei391@huawei.com>
Subject: Re: [PATCH] mtd: rawnand: fix drivers probe/remove methods
Date: Thu, 19 May 2022 17:25:07 +0200 [thread overview]
Message-ID: <20220519172507.4d9872c3@xps-13> (raw)
In-Reply-To: <20220517060753.26710-1-wupeng58@huawei.com>
Hi,
wupeng58@huawei.com wrote on Tue, 17 May 2022 06:07:53 +0000:
> Driver should call pci_disable_device() if it returns from
> cafe_nand_probe() with error.
>
> Meanwhile, the driver calls pci_enable_device() in
> cafe_nand_probe(), but never calls pci_disable_device()
> during removal.
Please fix the subject prefix, it should be "mtd: ranwnand: cafe:"
Also Fixes/Cc: stable tags might be useful.
> Signed-off-by: Peng Wu <wupeng58@huawei.com>
> ---
> drivers/mtd/nand/raw/cafe_nand.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/nand/raw/cafe_nand.c b/drivers/mtd/nand/raw/cafe_nand.c
> index 9dbf031716a6..af119e376352 100644
> --- a/drivers/mtd/nand/raw/cafe_nand.c
> +++ b/drivers/mtd/nand/raw/cafe_nand.c
> @@ -679,8 +679,10 @@ static int cafe_nand_probe(struct pci_dev *pdev,
> pci_set_master(pdev);
>
> cafe = kzalloc(sizeof(*cafe), GFP_KERNEL);
> - if (!cafe)
> - return -ENOMEM;
> + if (!cafe) {
> + err = -ENOMEM;
> + goto out_disable_device;
> + }
>
> mtd = nand_to_mtd(&cafe->nand);
> mtd->dev.parent = &pdev->dev;
> @@ -801,6 +803,8 @@ static int cafe_nand_probe(struct pci_dev *pdev,
> pci_iounmap(pdev, cafe->mmio);
> out_free_mtd:
> kfree(cafe);
> + out_disable_device:
> + pci_disable_device(pdev);
> out:
> return err;
> }
> @@ -822,6 +826,7 @@ static void cafe_nand_remove(struct pci_dev *pdev)
> pci_iounmap(pdev, cafe->mmio);
> dma_free_coherent(&cafe->pdev->dev, 2112, cafe->dmabuf, cafe->dmaaddr);
> kfree(cafe);
> + pci_disable_device(pdev);
> }
>
> static const struct pci_device_id cafe_nand_tbl[] = {
Thanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2022-05-19 15:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-17 6:07 [PATCH] mtd: rawnand: fix drivers probe/remove methods Peng Wu
2022-05-19 15:25 ` Miquel Raynal [this message]
2022-05-20 3:33 ` wupeng (D)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220519172507.4d9872c3@xps-13 \
--to=miquel.raynal@bootlin.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=liwei391@huawei.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
--cc=wupeng58@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox