public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Haowen Bai <baihaowen@meizu.com>
Cc: Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	<linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] xfs: drop the useless LIST_HEAD in __mtd_del_partition()
Date: Fri, 27 May 2022 12:45:21 +0200	[thread overview]
Message-ID: <20220527124521.15ac865e@xps-13> (raw)
In-Reply-To: <1653645678-29049-1-git-send-email-baihaowen@meizu.com>

Hi Haowen,

baihaowen@meizu.com wrote on Fri, 27 May 2022 18:01:18 +0800:

> Drop LIST_HEAD where the variable it declares is never used.
> 
> Signed-off-by: Haowen Bai <baihaowen@meizu.com>

The title seems wrong. A fixes tag would be appropriate.

> ---
>  drivers/mtd/mtdpart.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/mtd/mtdpart.c b/drivers/mtd/mtdpart.c
> index d442fa94c872..976e9c30244e 100644
> --- a/drivers/mtd/mtdpart.c
> +++ b/drivers/mtd/mtdpart.c
> @@ -326,7 +326,6 @@ static int __mtd_del_partition(struct mtd_info *mtd)
>  static int __del_mtd_partitions(struct mtd_info *mtd)
>  {
>  	struct mtd_info *child, *next;
> -	LIST_HEAD(tmp_list);
>  	int ret, err = 0;
>  
>  	list_for_each_entry_safe(child, next, &mtd->partitions, part.node) {


Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

      reply	other threads:[~2022-05-27 10:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-27 10:01 [PATCH] xfs: drop the useless LIST_HEAD in __mtd_del_partition() Haowen Bai
2022-05-27 10:45 ` Miquel Raynal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220527124521.15ac865e@xps-13 \
    --to=miquel.raynal@bootlin.com \
    --cc=baihaowen@meizu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=richard@nod.at \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox