public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Christian Lamparter <chunkeey@gmail.com>
To: linux-mtd@lists.infradead.org
Cc: dev@aboehler.at, miquel.raynal@bootlin.com
Subject: [PATCH] Revert "mtd: rawnand: add support for Toshiba TC58NVG0S3HTA00 NAND flash"
Date: Mon,  6 Jun 2022 21:29:52 +0200	[thread overview]
Message-ID: <20220606192952.34957-1-chunkeey@gmail.com> (raw)
In-Reply-To: <20220606155919.23001410@xps-13>

This reverts commit 3380557fc7e28d9bce7607e16d98f123d36da4ca.

It turned out this "4-byte" ID might have been an honest mistake.
Regrettably, the chip Andreas has might be a counterfeit or is
damaged in some other way and shouldn't have ended up in a router.

Andreas reported his chip is returning just four bytes:
"98 f1 80 15 00 00 00 00".

However, according to Kioxia/Toshiba's datasheet, there should
have been at least another byte that would have contained the
correct OOB size that Andreas needed.

Thanks to Peter-vdL for reporting this issue and Hannu Nyman
as well as neg2led who did the debugging.

Cc: Andreas B<C3><B6>hler <dev@aboehler.at>
BugLink: https://github.com/openwrt/openwrt/issues/9962
Signed-off-by: Christian Lamparter <chunkeey@gmail.com>
---
 drivers/mtd/nand/raw/nand_ids.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/mtd/nand/raw/nand_ids.c b/drivers/mtd/nand/raw/nand_ids.c
index 88c2440b47d8..dacc5529b3df 100644
--- a/drivers/mtd/nand/raw/nand_ids.c
+++ b/drivers/mtd/nand/raw/nand_ids.c
@@ -29,9 +29,6 @@ struct nand_flash_dev nand_flash_ids[] = {
 	{"TC58NVG0S3E 1G 3.3V 8-bit",
 		{ .id = {0x98, 0xd1, 0x90, 0x15, 0x76, 0x14, 0x01, 0x00} },
 		  SZ_2K, SZ_128, SZ_128K, 0, 8, 64, NAND_ECC_INFO(1, SZ_512), },
-	{"TC58NVG0S3HTA00 1G 3.3V 8-bit",
-		{ .id = {0x98, 0xf1, 0x80, 0x15} },
-		  SZ_2K, SZ_128, SZ_128K, 0, 4, 128, NAND_ECC_INFO(8, SZ_512), },
 	{"TC58NVG2S0F 4G 3.3V 8-bit",
 		{ .id = {0x98, 0xdc, 0x90, 0x26, 0x76, 0x15, 0x01, 0x08} },
 		  SZ_4K, SZ_512, SZ_256K, 0, 8, 224, NAND_ECC_INFO(4, SZ_512) },
-- 
2.36.1


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2022-06-06 19:31 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-20 10:40 [PATCH] mtd: rawnand: add support for Toshiba TC58NVG0S3HTA00 NAND flash Andreas Böhler
2022-04-21  7:36 ` Miquel Raynal
2022-06-05 15:31 ` Christian Lamparter
2022-06-06 13:59   ` Miquel Raynal
2022-06-06 19:29     ` Christian Lamparter [this message]
2022-06-07  6:13       ` [PATCH] Revert "mtd: rawnand: add support for Toshiba TC58NVG0S3HTA00 NAND flash" Miquel Raynal
2022-06-07 18:59         ` [PATCH v2] " Christian Lamparter
2022-06-09 13:10           ` Miquel Raynal
2022-06-06 19:37     ` [PATCH] mtd: rawnand: add support for Toshiba TC58NVG0S3HTA00 NAND flash Christian Lamparter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220606192952.34957-1-chunkeey@gmail.com \
    --to=chunkeey@gmail.com \
    --cc=dev@aboehler.at \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox